-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Closed
Description
Background
Follows up from:
- Expose builtin block Sass variables as CSS variables #35173
- Convert builtin block Sass variables into CSS variables #35306
The goal of this task is to entirely convert the Sass in the ./xmodule/ directory into vanilla CSS which can be loaded with the standard ResourceLoader class from xblock.utils. The immediate benefit is that we can remove the xmodule Sass build steps from edx-platform. The longer-term benefit is that this will remove any Sass build concerns from the xblock extraction effort.
Tasks
- Ensure Sass has been compiled into uncompressed CSS (
npm run compile-sass-dev). - Copy all the built-in compiled XBlock CSS (
lms/static/css/*Display.cssandlms/static/css/*Editor.css) into xmodule/assets. Add those CSS files to version control. - For each XBlock with Sass: Replace its
add_sass_to_fragmentcall with standard usage of axblock.utils.resources.ResourceLoaderandfragment.add_css. - Remove the definition of
add_sass_to_fragmentfrom xmodule.util.builtin_assets.py - Remove all
.scssfiles under xmodule/assets - Remove all
compile_sass_dir(...)calls in scripts/compile_sass.sh which compile Sass under xmodule/assets. - Update
xmodule/assets/README.rst
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
✅ Done