Skip to content

Script to print xsslint violations is missing #35965

@kdmccormick

Description

@kdmccormick

This was discovered as an existing issue while working on #35159

When xsslint detects a violation beyond the forgiven thresholds, rather than printing anything helpful, it fails with:

python scripts/xsslint/xss_linter.py \
--rule-totals \
--config=scripts.xsslint_config \
--thresholds=scripts/xsslint_thresholds.json
xsslint
FAILURE: XSSLinter Failed.
Too many violations total (65).
The limit is 64.
Too many python-concat-html violations (1).
The python-concat-html limit is 0.
run the following command to hone in on the problem:
./scripts/xss-commit-linter.sh -h
make: *** [Makefile:176: xsslint] Error 1

The script it tells you to run, ./scripts/xss-commit-linter.sh -h, does not exist.

We should provide the dev some way of seeing violations. Or, maybe we just print the violations every single time, like eslint does.

Metadata

Metadata

Assignees

No one assigned

    Labels

    code healthProactive technical investment via refactorings, removals, etc.help wantedReady to be picked up by anyone in the community

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions