Wrong message in batch enrollment

[angonz]

I propose to roll back PR #32837 as the messages do not reflect the actual behavior.

As stated by @fghaas,

We just came across this after upgrading our platform to Quince. Can I suggest that this patch be reverted? The error message contradicts what is actually happening.

When an instructor (or the bulk enrollment API) adds a learner email address to a course that does not belong to a registered user, then that learner receives an email inviting them to register on the platform, and once they complete their registration, they are automatically enrolled in the course they have been invited to. This behavior has not recently changed, as far as I am aware.

"Email cannot be sent to the following users via batch enrollment" clearly says that those users did not receive an email message, but that is not true: they do. It is not an enrollment message, strictly speaking, but an invitation to register, but an email does go out and thus "email cannot be sent" is not the right message to display here.

Originally posted by @fghaas in #32837 (comment)

[rayzhou-bit]

There is currently an open TNL ticket on batch enrollment behavior. The issue described in the ticket is that despite the error message Email cannot be sent to the following users via batch enrollment. They will be enrolled once they register., registration emails (not enrollment emails) are sent to the accounts. The caveat is that this only happens when all emails in the batch enrollment list do not have edX accounts. The behavior described by @fghaas and the ticket matches as long as we keep that caveat in mind.

If I remember correctly, there are a lot of small details on the batch enrollment process.

• What stage the account is at (created account vs unactivated account vs fully activated account).
• What the code considers batch enrollment. For example, having 1 email in the batch enrollment list doesn't trigger the batch enrollment portion of the code.

Next step would be testing our current behavior with batch enrollment and accounts at various stages of activation progress. @jristau1984 should I dig in further on that or should this go to TNL?

---

Some other relevant links:

• 2U documentation: https://2u-internal.atlassian.net/wiki/spaces/ENGAGE/pages/12025987/Account+Activation#Account-activation-for-enrollment
• enroll_email code: https://github.com/openedx/edx-platform/blob/bb9d0b27c01f2335735126959b926f8f2171fb8d/lms/djangoapps/instructor/enrollment.py#L143-L143

[rayzhou-bit]

I updated the open TNL ticket TNL-11014 with information here along with suggested next steps to get behavior and messaging aligned.
Closing this ticket out.