[Test failure] <TC-00065>: Course search pill not cleared when text deleted

[saraburns1]

Release

Ulmo

Expected behavior

I am able to clear my search by clicking X on the pill with my search term on it that appears under the search bar OR by deleting the search term in the search bar and clicking search or hitting enter

When i delete the search term in the search bar and click search, the search term under the bar (with the X) should disappear

Actual behavior

Pill with search term under the bar remains even when search bar text is cleared & all courses are returned

search results:

after deleting search bar text:

Steps to reproduce

1. Go to https://ulmo.demo.edly.io/courses
2. Type 'test' in search bar and hit enter
3. Delete 'test' from search bar and hit enter
4. See 'test' box still under search bar even though all 14 results are being shown

Additional information

No response

[BryanttV]

Hello @saraburns1, thanks!

I was testing in the sandbox, and the reported issue is indeed happening. I also tested in a Redwood and Teak environment, and the same thing occurs.

Although the filter in the search does get cleared and works correctly, the pill with the old term still appears, which is confusing. A simple solution is to remove that filter when the search is performed if the input is empty.

I tested something like this locally, and it works well:

dispatcher.listenTo(form, 'search', function(query) {
    form.showLoadingIndicator();
    if (!query || query.trim() === '') {
        filters.remove('search_query');
    }
    search.performSearch(query, filters.getTerms());
});

tc-00065.mp4

[Asespinel]

The suggested solution is ready to review in this PR: #37709

[Asespinel]

The original PR was merged into master and I opened a backport for ulmo here: #37734

cc: @magajh

[magajh]

The backport for ulmo was merged