Fix display course specific user teams#10804
Merged
Conversation
Contributor
Author
|
@awaisdar001 @Shrhawk can anyone of you do initial review please ? |
mushtaqak
force-pushed
the
mushtaq/tnl3825-fix-show-user-course-specific-team
branch
from
eed250b to
bc8013a
Compare
Contributor
Author
|
@adampalay can you please review :) |
Contributor
There was a problem hiding this comment.
what's this re doing? Is there a way to do this without regular expressions?
Contributor
|
this looks great; just a comment about the test :) |
mushtaqak
force-pushed
the
mushtaq/tnl3825-fix-show-user-course-specific-team
branch
from
bc8013a to
e513c94
Compare
mushtaqak
force-pushed
the
mushtaq/tnl3825-fix-show-user-course-specific-team
branch
from
e513c94 to
1d57ef2
Compare
Contributor
Author
|
@dianakhuang @adampalay May you please review. Thanks. |
Contributor
|
👍 Great that the fix was simple. And the tests are good. |
Contributor
There was a problem hiding this comment.
sorry, I didn't realize we were expecting JSON here! Why don't you do:
team_count = json.loads(response.content)['teams']['count']
and then check team_count is what you expect it to be?
Contributor
There was a problem hiding this comment.
I've been corrected — JSON isn't being returned here.
Contributor
|
👍 |
Contributor
Author
|
@adampalay @dianakhuang Thanks. I will merge now :) |
mushtaqak
pushed a commit
that referenced
this pull request
Dec 7, 2015
…se-specific-team Fix display course specific user teams
adampalay
deleted the
mushtaq/tnl3825-fix-show-user-course-specific-team
branch
This was referenced Jul 5, 2023
robrap
added a commit
that referenced
this pull request
Jul 7, 2023
The original tests looked like helpers, but we are guessing that they were supposed to be tests. Additionally, one test had a small bug as written. It would be more resilient to actually parse the JSON, but that work is being left for a later time. For now, it works, but is not resilient. The original PR can be found here: #10804
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After you have joined one team in one course, that team shows up under 'My Team' for all courses.
Fix course specific user teams in teams tab