bokchoy tests for move xblocks by muhammad-ammar · Pull Request #14465 · openedx/openedx-platform

muhammad-ammar · 2017-02-03T15:27:33Z

No description provided.

muzaffaryousaf · 2017-02-09T14:18:32Z

@muhammad-ammar Can you ask for assistance someone from test engineering about the a11y test failure.

muzaffaryousaf · 2017-02-09T11:26:26Z

common/test/acceptance/tests/studio/test_studio_container.py

+            )
+        )
+
+    def verify_move_opertions(self, operation, component_display_names_after_operation):


opertions --> operations

muhammad-ammar · 2017-02-09T14:57:54Z

common/test/acceptance/tests/studio/test_studio_container.py

+            component_display_names_after_operation=['HTML 11', 'HTML 12']
+        )
+
+    def test_a11y(self):


@jzoldak @benpatterson If i decorate this test with attr('a11y') then this test fails always due to same failure reason. From the screenshot it looks like that outline page never finishes loading but i am unable to understand the reason of failure. Test passes without attr('a11y'). Also test passes on devstack with attr('a11y').

Any idea why the tests fails with attr('a11y') on jenkins?

muhammad-ammar · 2017-02-10T07:43:56Z

jenkins run python

benpatterson · 2017-02-10T13:48:49Z

@muhammad-ammar have you tried to reproduce locally?

There was a point in which a11y tests were run through phantomjs instead of firefox. I honestly don't remember if that's what the configuration is now, though. You'd have to dig around pavelib (most likely) to determine that.

benpatterson · 2017-02-10T13:49:35Z

(or, it'll be obvious if you attempt to reproduce locally and you have x11 forwarding enabled)

muhammad-ammar · 2017-02-10T14:02:03Z

@benpatterson
paver test_a11y -t studio/test_studio_container.py:MoveComponentTest.test_a11y --testsonly --fasttest passes the test locally but it is running the test using Firefox(don't know why) instead of phantomjs.

Do i need to run the test using phantomjs? If yes then how the x11 forwarding will help because phantomjs is headless browser.

benpatterson · 2017-02-10T14:19:02Z

@muhammad-ammar I only mention that because with phantomjs you'd see no window whereas with firefox, you would. It would be a proxy for confirming that it's running on phantomjs if you don't want to look at code. But...it sounds like you've confirmed it's on firefox, so: great. I couldn't answer your question at this point, then, without a closer look at the code. I would guess it's a flaky condition. You may want to ping Raees or Muddasser to help you isolate the problem.

muzaffaryousaf · 2017-02-27T13:45:14Z

common/test/acceptance/tests/studio/test_studio_container.py

+        unit_page.a11y_audit.config.set_rules({
+            'ignore': [
+                'color-contrast',
+                'link-href',


@mushtaqak can we add ticket references with these ignore rules ?

muzaffaryousaf · 2017-02-27T14:06:04Z

common/test/acceptance/tests/studio/test_studio_container.py

+                    ),
+                ],
+            },
+        })


@mushtaqak Let's move these settings in setup.

muzaffaryousaf · 2017-02-27T14:06:32Z

common/test/acceptance/tests/studio/test_studio_container.py

+
+        # Add split test to unit_page1 and assign newly created group configuration to it
+        split_test = XBlockFixtureDesc('split_test', 'Test Content Experiment', metadata={'user_partition_id': 0})
+        self.course_fixture.create_xblock(self.unit_page1.locator, split_test)


I would move this in setup where we're add other fixtures.

We are only using split_test in this test, so I don't think we should add it to all other tests

muzaffaryousaf · 2017-02-27T14:09:07Z

common/test/acceptance/tests/studio/test_studio_container.py

+        When I go to unit page in second section
+        Then I see moved component there
+        When I undo move a component
+        Then I verified that undo move operation is successful


Given that I am a staff user And I go to content experiment page And I open the move dialogue modal When I navigate to the unit in second section Then I see move button is enabled And when I click on the move button Then I see move operation success message And when I click on take me there link Then I see moved component there

muzaffaryousaf · 2017-02-27T14:11:05Z

common/test/acceptance/tests/studio/test_studio_container.py

+        When I go to unit page in second section
+        Then I see moved component there
+        When I undo move a component
+        Then I verified that undo move operation is successful


@mushtaqak How you're doing move and then undo move after take me there link ?

@muzaffaryousaf we are doing move initially and then checking confirmation message, if it is only move operation, we are checking take me there link otherwise we do undo move and check it's confirmation as well.

muzaffaryousaf · 2017-02-27T14:13:29Z

common/test/acceptance/pages/studio/container.py


+        def _loading_spinner_hidden():
+            """ promise function to check loading spinner state """
+            is_spinner_hidden = self.q(css='div.ui-loading.is-hidden').present


present or visible ??

present because we are checking if the element has this class or not

Are we not checking for visibility of loader ?

yes based on it's is-hidden class.

FYI @muhammad-ammar

muzaffaryousaf · 2017-02-27T14:14:44Z

common/test/acceptance/pages/studio/container.py

+        """
+        click_css(self, '#page-alert .alert.confirmation .nav-actions .action-primary')
+
+    def click_take_me_link(self):


click_take_me_there_link

muzaffaryousaf · 2017-02-27T14:24:28Z

common/test/acceptance/tests/studio/test_studio_container.py

+            component_display_names_after_operation
+        )
+
+    def test_move(self):


test_move_component_successfully or test_move_successfully

muzaffaryousaf · 2017-02-28T07:38:45Z

common/test/acceptance/tests/studio/test_studio_container.py

+        Then I click on the move button
+        Then I see move operation successful message
+        When I go to unit page in second section
+        Then I see moved component there


Given I am a staff user And I go to unit page in first section And I open the move modal And I navigate to unit in second section And I see move button is enabled When I click on the move button Then I see move operation success message And When I click on take me there link Then I see moved component there.

muzaffaryousaf · 2017-02-28T07:41:30Z

common/test/acceptance/tests/studio/test_studio_container.py

+        Then I click on the move button
+        Then I see move operation successful message
+        When I clicked on undo move link
+        Then I verified that undo move operation is successful


Change this one too. Just like others.

muzaffaryousaf · 2017-02-28T08:00:48Z

common/test/acceptance/tests/studio/test_studio_container.py

+    def test_a11y(self):
+        """
+        Verify move modal a11y.
+        """


can you add doc strings.

muzaffaryousaf · 2017-02-28T09:45:45Z

👍 Except few nits.

muhammad-ammar force-pushed the ammar/bokchoy-tests branch from 3d96ddf to 0c90007 Compare February 6, 2017 13:45

mushtaqak force-pushed the mushtaq/tnl-6062-save-move-xblock branch from 2149952 to 486bcde Compare February 7, 2017 10:36

muhammad-ammar force-pushed the ammar/bokchoy-tests branch from 0c90007 to 0f5423a Compare February 7, 2017 10:57

mushtaqak force-pushed the mushtaq/tnl-6062-save-move-xblock branch from 486bcde to 99a3416 Compare February 7, 2017 16:25

muhammad-ammar force-pushed the ammar/bokchoy-tests branch from 0f5423a to dd5b9a9 Compare February 8, 2017 07:41

mushtaqak force-pushed the mushtaq/tnl-6062-save-move-xblock branch 2 times, most recently from c4c0d45 to cda669e Compare February 9, 2017 08:49

muhammad-ammar force-pushed the ammar/bokchoy-tests branch 2 times, most recently from c46e0ce to 1a06373 Compare February 9, 2017 09:05

muhammad-ammar requested a review from muzaffaryousaf February 9, 2017 11:00

muzaffaryousaf reviewed Feb 9, 2017

View reviewed changes

muhammad-ammar commented Feb 9, 2017

View reviewed changes

muhammad-ammar force-pushed the ammar/bokchoy-tests branch from 6662ee7 to 6044928 Compare February 10, 2017 06:50

mushtaqak force-pushed the mushtaq/tnl-6062-save-move-xblock branch from 64c779a to 968207e Compare February 14, 2017 13:16

muzaffaryousaf assigned mushtaqak Feb 15, 2017

muhammad-ammar force-pushed the ammar/bokchoy-tests branch from 6044928 to 270c256 Compare February 15, 2017 09:19

mushtaqak changed the base branch from mushtaq/tnl-6062-save-move-xblock to mushtaq/move-component February 17, 2017 13:30

mushtaqak force-pushed the ammar/bokchoy-tests branch from 270c256 to 79adfa5 Compare February 27, 2017 13:30

mushtaqak changed the base branch from mushtaq/move-component to mushtaq/restrict-move-action February 27, 2017 13:30

muzaffaryousaf reviewed Feb 27, 2017

View reviewed changes

common/test/acceptance/tests/studio/test_studio_container.py

),

],

},

})

Copy link

muzaffaryousaf Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mushtaqak Let's move these settings in setup.

muzaffaryousaf reviewed Feb 27, 2017

View reviewed changes

muzaffaryousaf reviewed Feb 28, 2017

View reviewed changes

mushtaqak force-pushed the ammar/bokchoy-tests branch 2 times, most recently from 58527d1 to f13fc59 Compare March 1, 2017 13:32

mushtaqak force-pushed the mushtaq/restrict-move-action branch from 965c31f to 93439b2 Compare March 1, 2017 14:03

mushtaqak force-pushed the ammar/bokchoy-tests branch from f13fc59 to ddf809e Compare March 1, 2017 14:20

mushtaqak force-pushed the mushtaq/restrict-move-action branch from 93439b2 to 485ffb1 Compare March 1, 2017 14:30

muhammad-ammar and others added 2 commits March 1, 2017 19:31

bokchoy tests for move xblocks

8a1ec3e

Add content experiment test

83de1eb

mushtaqak force-pushed the ammar/bokchoy-tests branch from ddf809e to 83de1eb Compare March 1, 2017 14:32

mushtaqak merged commit 0df3624 into mushtaq/restrict-move-action Mar 1, 2017

mushtaqak mentioned this pull request Mar 1, 2017

Move a component #14315

Merged

mushtaqak deleted the ammar/bokchoy-tests branch May 10, 2017 08:02

Conversation

muhammad-ammar commented Feb 3, 2017

Uh oh!

muzaffaryousaf commented Feb 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muhammad-ammar Feb 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muhammad-ammar commented Feb 10, 2017

Uh oh!

benpatterson commented Feb 10, 2017

Uh oh!

benpatterson commented Feb 10, 2017

Uh oh!

muhammad-ammar commented Feb 10, 2017

Uh oh!

benpatterson commented Feb 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muzaffaryousaf Feb 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muzaffaryousaf Feb 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muzaffaryousaf Feb 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muzaffaryousaf commented Feb 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

muhammad-ammar Feb 9, 2017 •

edited

Loading

muzaffaryousaf Feb 27, 2017 •

edited

Loading

muzaffaryousaf Feb 27, 2017 •

edited

Loading

muzaffaryousaf Feb 28, 2017 •

edited

Loading