Remove success banner on container state change#14659
Remove success banner on container state change#14659mushtaqak merged 1 commit intomushtaq/move-componentfrom
Conversation
There was a problem hiding this comment.
VisibilityState is not used in the file
|
@mushtaqak I'm not able to see i18n & logging in this PR. |
|
@muzaffaryousaf @muhammad-ammar review ? |
|
jenkins run js |
There was a problem hiding this comment.
Can we add coverage for this action ?
There was a problem hiding this comment.
I will see where we can add this, may be in bokchoy.
|
@mushtaqak I've only 1 question otherwise looks good. 👍 |
There was a problem hiding this comment.
@mushtaqak My only concern is that some of the above messages are not user friendly. We can release the changes now but we should create a new ticket to improve the log messages.
There was a problem hiding this comment.
Created the JIRA ticket : https://openedx.atlassian.net/browse/TNL-6678
There was a problem hiding this comment.
operation argument is missing docs
muhammad-ammar
left a comment
muhammad-ammar
left a comment
There was a problem hiding this comment.
👍 after green build
mushtaqak
force-pushed
the
mushtaq/remove-banner-logging
branch
2 times, most recently
from
046b595 to
d710262
Compare
Add i18n to backend error messages in case they appear to end user Remove success banner when trying to publish or discard changes on container page
mushtaqak
force-pushed
the
mushtaq/remove-banner-logging
branch
from
d710262 to
cb2d78b
Compare
|
jenkins run js |
3 participants
This PR adds the following capabilities to move feature :
Sandbox