Skip to content

added exception decorator #17984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
irfanuddinahmad merged 1 commit into from
Apr 26, 2018
Merged

added exception decorator #17984

irfanuddinahmad merged 1 commit into from
Apr 26, 2018

Conversation

@irfanuddinahmad
Copy link
Contributor

@irfanuddinahmad irfanuddinahmad commented Apr 18, 2018

No description provided.

@irfanuddinahmad irfanuddinahmad self-assigned this Apr 18, 2018
@edx-status-bot
Copy link

edx-status-bot commented Apr 18, 2018

Your PR has finished running tests.

@mushtaqak
Copy link
Contributor

mushtaqak commented Apr 18, 2018

jenkins run js

@edx-status-bot
Copy link

edx-status-bot commented Apr 18, 2018

Your PR has finished running tests.

1 similar comment
@edx-status-bot
Copy link

edx-status-bot commented Apr 20, 2018

Your PR has finished running tests.

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/exception_decorator branch 2 times, most recently from 5aedfaa to a1570b2 Compare April 23, 2018 16:31
@edx-status-bot
Copy link

edx-status-bot commented Apr 23, 2018

Your PR has finished running tests.

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/exception_decorator branch from a1570b2 to be16688 Compare April 24, 2018 06:58
muhammad-ammar
muhammad-ammar approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 after build is green

@edx-status-bot
Copy link

edx-status-bot commented Apr 24, 2018

Your PR has finished running tests.

@irfanuddinahmad
Copy link
Contributor Author

irfanuddinahmad commented Apr 24, 2018

jenkins run all

@edx-status-bot
Copy link

edx-status-bot commented Apr 24, 2018

Your PR has finished running tests.

@irfanuddinahmad
Copy link
Contributor Author

irfanuddinahmad commented Apr 24, 2018

jenkins run a11y

@edx-status-bot
Copy link

edx-status-bot commented Apr 24, 2018

Your PR has finished running tests.

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/exception_decorator branch from be16688 to 0ccee62 Compare April 25, 2018 14:13
@irfanuddinahmad
Copy link
Contributor Author

irfanuddinahmad commented Apr 25, 2018

jenkins run all

2 similar comments
@mushtaqak
Copy link
Contributor

mushtaqak commented Apr 25, 2018

jenkins run all

@mushtaqak
Copy link
Contributor

mushtaqak commented Apr 25, 2018

jenkins run all

@edx-status-bot
Copy link

edx-status-bot commented Apr 25, 2018

Your PR has finished running tests.

@irfanuddinahmad
Copy link
Contributor Author

irfanuddinahmad commented Apr 25, 2018

jenkins run all

mushtaqak
mushtaqak approved these changes Apr 25, 2018
View reviewed changes
Copy link
Contributor

@mushtaqak mushtaqak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 when green build. I guess we should have a better name for the decorator.

cms/djangoapps/contentstore/tests/test_transcripts_utils.py Outdated
Copy link
Contributor

@mushtaqak mushtaqak Apr 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: test_get_transcript_contentstore_exceptions

common/lib/xmodule/xmodule/video_module/transcripts_utils.py Outdated
Copy link
Contributor

@mushtaqak mushtaqak Apr 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: handle_transcript_exceptions

@mushtaqak
Copy link
Contributor

mushtaqak commented Apr 25, 2018

@irfanuddinahmad @muhammad-ammar Are these only places where we have to throw not found exceptions ?

@edx-status-bot
Copy link

edx-status-bot commented Apr 25, 2018

Your PR has finished running tests.

3 similar comments
@edx-status-bot
Copy link

edx-status-bot commented Apr 25, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Apr 25, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Apr 25, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Apr 25, 2018

Your PR has finished running tests.

2 similar comments
@edx-status-bot
Copy link

edx-status-bot commented Apr 25, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Apr 25, 2018

Your PR has finished running tests.

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/exception_decorator branch from 0ccee62 to b637359 Compare April 26, 2018 06:31
@edx-status-bot
Copy link

edx-status-bot commented Apr 26, 2018

Your PR has finished running tests.

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/exception_decorator branch from b637359 to bfbeeb1 Compare April 26, 2018 11:02
@edx-status-bot
Copy link

edx-status-bot commented Apr 26, 2018

Your PR has finished running tests.

@irfanuddinahmad irfanuddinahmad merged commit f5eeec0 into transcripts-phase-2 Apr 26, 2018
@irfanuddinahmad irfanuddinahmad deleted the iahmad/exception_decorator branch April 26, 2018 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@muhammad-ammar muhammad-ammar muhammad-ammar approved these changes

@mushtaqak mushtaqak mushtaqak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@irfanuddinahmad irfanuddinahmad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@irfanuddinahmad @edx-status-bot @mushtaqak @muhammad-ammar