basic tab attach uploads with edx_video_id #18032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR has finished running tests. |
muhammad-ammar
force-pushed
the
ammar/EDUCATOR-2761-basic-tab-upload-edx-video-id
branch
from
a051525 to
aa4face
Compare
|
Your PR has finished running tests. |
muhammad-ammar
force-pushed
the
ammar/EDUCATOR-2761-basic-tab-upload-edx-video-id
branch
from
aa4face to
eef8f27
Compare
|
Your PR has finished running tests. |
Contributor
Author
|
jenkins run bokchoy |
Contributor
Author
|
jenkins run a11y |
|
Your PR has finished running tests. |
mushtaqak
approved these changes
Apr 25, 2018
| edx_video_id=non_existant_edx_video_id | ||
| ) | ||
| # Verify the response | ||
| self.assert_response(response, expected_status_code=400, expected_message='Invalid Video ID') |
| validated_data.update({ | ||
| 'video': video, | ||
| 'edx_video_id': clean_video_id(video.edx_video_id), | ||
| 'edx_video_id': clean_video_id(edx_video_id) or clean_video_id(video.edx_video_id), |
Contributor
There was a problem hiding this comment.
I think we have success scenario test written for edx_video_id coming from video.edx_video_id but not from the request data.
| 'js/views/video/transcripts/utils' | ||
| ], | ||
| function($, Backbone, _, Utils) { | ||
| function($, Backbone, _, TranscriptUtils) { |
Contributor
There was a problem hiding this comment.
This wasn't previously being used ?
muhammad-ammar
force-pushed
the
ammar/EDUCATOR-2761-basic-tab-upload-edx-video-id
branch
from
eef8f27 to
b2f40cd
Compare
|
Your PR has finished running tests. |
muhammad-ammar
force-pushed
the
ammar/add-check-transcript-ajax-on-basic-tab
branch
from
d7b5b6b to
88c2a08
Compare
muhammad-ammar
force-pushed
the
ammar/EDUCATOR-2761-basic-tab-upload-edx-video-id
branch
from
b2f40cd to
df8cfed
Compare
|
Your PR has finished running tests. |
muhammad-ammar
force-pushed
the
ammar/EDUCATOR-2761-basic-tab-upload-edx-video-id
branch
from
df8cfed to
629efd8
Compare
|
Your PR has finished running tests. |
Contributor
Author
|
@mushtaqak feedback addressed plus added jasmine tests |
mushtaqak
approved these changes
Apr 26, 2018
muhammad-ammar
force-pushed
the
ammar/add-check-transcript-ajax-on-basic-tab
branch
from
88c2a08 to
388649b
Compare
|
Your PR has finished running tests. |
muhammad-ammar
force-pushed
the
ammar/add-check-transcript-ajax-on-basic-tab
branch
from
388649b to
35611e7
Compare
muhammad-ammar
force-pushed
the
ammar/EDUCATOR-2761-basic-tab-upload-edx-video-id
branch
from
9556ce2 to
5d218e7
Compare
|
Your PR has finished running tests. |
muhammad-ammar
force-pushed
the
ammar/add-check-transcript-ajax-on-basic-tab
branch
from
4ce3382 to
c02955d
Compare
EDUCATOR-2761
EDUCATOR-2752
muhammad-ammar
force-pushed
the
ammar/EDUCATOR-2761-basic-tab-upload-edx-video-id
branch
from
5d218e7 to
84ab9ca
Compare
|
Your PR has finished running tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDUCATOR-2761