Consolidate user login and authentication code#18917
Merged
nasthagiri merged 1 commit intomasterfrom Sep 15, 2018
Merged
Conversation
nasthagiri
force-pushed
the
arch/user-authn-app
branch
7 times, most recently
from
99d8730 to
2756c04
Compare
nasthagiri
force-pushed
the
arch/user-authn-app
branch
from
2f8c51f to
2fb9b71
Compare
robrap
requested changes
Sep 13, 2018
Contributor
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
Big step in the right direction. Thanks.
robrap
approved these changes
Sep 13, 2018
Contributor
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
Approve of what I reviewed once tests are passing. Let me know if you need a re-review on any final changes.
nasthagiri
force-pushed
the
arch/user-authn-app
branch
4 times, most recently
from
7bc367c to
161ada0
Compare
nasthagiri
force-pushed
the
arch/user-authn-app
branch
from
161ada0 to
8cf4428
Compare
|
Your PR has finished running tests. There were no failures. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Wednesday, September 19, 2018. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
Contributor
|
FYI: @dianakhuang: Here is the refactor with a couple of small deletions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates the actively used code related to login/logout and user authentication in the platform - as a runway for future immediate work in this area.
Specifically: