distinguish between grader type and grader type display (STUD-989)#2038
distinguish between grader type and grader type display (STUD-989)#2038
Conversation
There was a problem hiding this comment.
probably should call get_text('Not Graded') and also in the != test below this (perhaps test != u'Not Graded' and != get_text('Not Graded')) yuck. Hmmm, I need to read thru all the code for this page not just what's in this PR to figure this out. I'll look at it friday.
There was a problem hiding this comment.
Okay, the problem is that L227 in item.py can't handle None as an asserted value for grader_type as None may mean that it wasn't provided. Perhaps change L129 to give a different default if 'graderType' is missing so that None means 'graderType' == None? Then you can get rid of the 'Not Graded' references (L176, L182) in this file, There are probably other changes.
In general, I think the value should be None/null for not set and the client should be the only one that knows it should use the l10n 'Not Graded' string w/ its unique display formatting.
* addition of test code of the certificate issuance function openedx#2038 (openedx#2054) * Mod translation of 'Course End Date:' openedx#2084 (openedx#2090) * Add menu to ga_operation for ga_analyzer openedx#2039 (openedx#2088) * Fixed bugs openedx#2039 (openedx#2112) * Fixed csv format openedx#2039 (openedx#2127) * Change to split download if there are many display items openedx#916 (openedx#2121) * Change to split download if there are many display items openedx#916 * Fix UT * Fix Review * Fix review2
Releasing `0.12.10`
2 participants
Distinguishes between graderType and display in order to allow "Not Graded" to be internationalized.
@dmitchell , is this what you had in mind for https://edx-wiki.atlassian.net/browse/STUD-989?
@zubair-arbi