Added hostname argument to openended_post command.#2133
Conversation
There was a problem hiding this comment.
It would be cleaner to modify the DummyRequest class in utils.py but it is used for grading too. So to keep the changes isolated I have defined a new one. I can modify the other one too instead.
There was a problem hiding this comment.
I think this is fine for now, since it's more conservative.
There was a problem hiding this comment.
why return at the end of __init__?
There was a problem hiding this comment.
Copy pasted. Will remove it.
There was a problem hiding this comment.
why was it in the other dummy request?
|
@cpennington @feanil Here is the hotfix PR. |
|
I think this is good to go. |
There was a problem hiding this comment.
If hostname is None, then this leaves request as None, and relies on get_module_for_student to create it. Why not just require get_module_for_student to always get a request, and always to request creation up here?
There was a problem hiding this comment.
I don't really follow: are you saying that we should lose L74-75?
I don't want to change the definition of get_module_for_student because it's used elsewhere in the openended command suite, and I want the amount of moving parts in this hotfix to remain at a minimum.
|
Other than my one comment, 👍 Also, we really need to make it so you don't need a request to get an XModule. =P |
There was a problem hiding this comment.
Do you need the conditional here, too?
There was a problem hiding this comment.
yes, because there are other commands that use this function
There was a problem hiding this comment.
that don't pass in request as a param
There was a problem hiding this comment.
it's not pretty, but again I just wanted to keep moving parts to a minimum for this hotfix
Added hostname argument to openended_post command.
* Add menu to ga_operation for ga_analyzer openedx#2039 (openedx#2088) * add role for old course viewer openedx#2062 (openedx#2087) * add role for old course viewer openedx#2062 * Change action for biz course by BetaTester role openedx#2062 * Construction of image server openedx#2025 (openedx#2106) * cherry-pick 8c8953f * Fix file upload in IE * Construction of image server openedx#2025 * add all keywords search in Student management openedx#2029 (openedx#2034) * Fix bug for before enrollment start in ga old course viewer openedx#2062 (openedx#2125) * fix. Construction of image server openedx#2025 (openedx#2117) * Modify message and css of enrollment for Course About openedx#2130 * Add a certificate list to user's profile page. openedx#2042 (openedx#2108) * Mod UT openedx#2130 * add PDF File Construction of image server openedx#2025 (openedx#2140) * add library option, and library links to the course. openedx#2001 (openedx#2124) * Invalid StudioPermissionsService object in API to show/save xblock settings in CMS. Randomized Content Block editor did not check Studio user's permissions * add library option, and library links to the course. openedx#2001 * fix. add all keywords search in Student management openedx#2029 (openedx#2034) (openedx#2157) * second fix. Construction of image server openedx#2025 (openedx#2158) * add library option, and library links to the course. openedx#2001 (openedx#2160) * third fix. Construction of image server openedx#2163 (openedx#2164) * Add filter by category for certificates on profile page openedx#2042 (openedx#2165) * Fix bug for add library option, and library links to the course. openedx#2162 openedx#2133 (openedx#2167) * Develop/dogwood/gacco201708 (openedx#2170) * Fixed bugs openedx#2039 (openedx#2112) * Fixed csv format openedx#2039 (openedx#2127) * Change to split download if there are many display items openedx#916 (openedx#2121) * Change to split download if there are many display items openedx#916 * Fix UT * Fix Review * Fix review2
3 participants
ORA-286