[TSD] adds annotations for XBLOCK_SELECT_FUNCTION#26164
[TSD] adds annotations for XBLOCK_SELECT_FUNCTION#26164robrap merged 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @eLRuLL! I've created OSPR-5556 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
97c10fa to
164035a
Compare
robrap
left a comment
There was a problem hiding this comment.
Thanks for the annotations. I've got some questions.
68339c5 to
b94a356
Compare
@robrap this is ready for review |
robrap
left a comment
There was a problem hiding this comment.
Minor issue. Thanks for the updates!
robrap
left a comment
There was a problem hiding this comment.
Thank you again. If you squash I can merge when green in the morning.
improves the setting_description for XBLOCK_SELECT_FUNCTION removes extra setting_description
5fe9a1a to
24f528c
Compare
squashed 👍 |
|
Your PR has finished running tests. There were no failures. |
|
@eLRuLL 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Settings variable:
XBLOCK_SELECT_FUNCTIONusage: