Skip to content

[BB-3171] Prevent race condition that can delete user input#26639

Closed
viadanna wants to merge 1 commit intoopenedx:masterfrom
open-craft:viadanna/profile-input-race
Closed

[BB-3171] Prevent race condition that can delete user input#26639
viadanna wants to merge 1 commit intoopenedx:masterfrom
open-craft:viadanna/profile-input-race

Conversation

@viadanna
Copy link
Contributor

This PR changes how Account fields are updated in the UI so that updating the fields in quick succession does not cause previous XHR requests to remove information.

JIRA tickets: BB-3171

Merge deadline: "None"

Testing instructions:

  1. Check out this branch in your master devstack.
  2. Log in to the LMS and go to your Account Settings.
  3. Open the DevTools and Enable slow 3G throttling.
  4. Update the Account information in quick succession, keeping an eye on the DevTools Network tab.
  5. Make sure no previously entered information is lost.

when the user is focused on an input, and the value of the input has
changed from the model, ignore field updates because these would delete
user input data.  This data will be submitted normally on finishEditing
@openedx-webhooks
Copy link

Thanks for the pull request, @viadanna! I've created OSPR-5633 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Feb 19, 2021
@edx-status-bot
Copy link

Your PR has finished running tests. The following contexts failed:

  • jenkins/quality

@natabene
Copy link
Contributor

@viadanna Thank you for your contribution. Please let me know once it is ready for our review.

@viadanna
Copy link
Contributor Author

This ended up being a duplicate of https://github.com/edx/edx-platform/pull/25950

@viadanna viadanna closed this Feb 24, 2021
@viadanna viadanna deleted the viadanna/profile-input-race branch February 24, 2021 13:47
@openedx-webhooks
Copy link

@viadanna Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments