-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: Emit course completion related events #28415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -106,3 +106,14 @@ | |
| # score that was created. | ||
| ] | ||
| ) | ||
|
|
||
|
|
||
| # This Signal indicates that the user has received a passing grade in the course for the first time. | ||
| # Any subsequent grade changes that may vary the passing/failing status will not re-trigger this event. | ||
| # Emits course grade passed first time event | ||
| COURSE_GRADE_PASSED_FIRST_TIME = Signal( | ||
|
||
| providing_args=[ | ||
| 'course_id', # Course object id | ||
| 'user_id', # User object id | ||
| ] | ||
| ) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[double checking] Are
event_transaction_idandevent_transaction_typemeaningful in these new events?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nasthagiri Added those for consistency with other events of grades. These fields might not be meaning full for xAPI/Caliper but could be meaningful for other backends like logging or segmentation and these fields are present in many of other events emits from edx-platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.