Skip to content

Conversation

@bradenmacdonald
Copy link
Contributor

Description

This is a backport of https://github.com/edx/edx-platform/pull/28019 to the Lilac master branch, as requested by @alfredchavez.

Summary:

xblock-poll's celery task was broken, then fixed in #23700, then broken again by #25479. This fixes it again.

Supporting information

See original PR.

Testing instructions

See original PR.

Deadline

None

Other information

.

@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! I've created OSPR-6192 to keep track of it in JIRA.

As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion.

@openedx-webhooks openedx-webhooks added core committer open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Oct 29, 2021
@bradenmacdonald bradenmacdonald changed the title Backport to Lilac master: xblock-poll's export to CSV feature is not working [TNL-8370] [MNG-2273] Backport to Lilac master: xblock-poll's export to CSV feature is not working [TNL-8370] [MNG-2273] [BB-4877] Oct 29, 2021
@natabene
Copy link
Contributor

natabene commented Nov 1, 2021

@bradenmacdonald Thank you for your contribution. Please let me know once this is ready for our review.

@natabene
Copy link
Contributor

natabene commented Nov 1, 2021

@BbrSofiane Please review when you have a chance.

Copy link
Contributor

@BbrSofiane BbrSofiane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edx-community-bot merge

@BbrSofiane
Copy link
Contributor

@edx-community-bot merge

@BbrSofiane
Copy link
Contributor

@edx-community-bot merge

@edx-community-bot edx-community-bot merged commit f69c460 into openedx:open-release/lilac.master Nov 1, 2021
@openedx-webhooks
Copy link

@ormsbee, @kdmccormick: thought you might like to know that bradenmacdonald merged this pull request.

@openedx-webhooks openedx-webhooks added merged and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. engineering review labels Nov 1, 2021
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@regisb
Copy link
Contributor

regisb commented Nov 1, 2021

Congrats for merging this 7 minutes before lilac.3 was tagged @BbrSofiane :)

@bradenmacdonald bradenmacdonald deleted the braden/lilac-backport-xblock-poll-fix branch November 1, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants