feat: trigger grade change event to message bus#29512
Closed
feat: trigger grade change event to message bus#29512
Conversation
|
Your PR has finished running tests. There were no failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trigger an event to the message bus at the same time as the API request to credentials on grade change. Part of the effort to gradually replace these API calls with events.
Useful information to include:
-- KAFKA_ENABLED
-- KAFKA_PRODUCER_CONF_BASE
-- SCHEMA_REGISTRY_URL
Right now kafka is only enabled on devstack since we don't have a real cluster set up yet.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Testing this change locally with devstack is a pain but can be done. You will need studio as well as all the kafka containers. You can bring up the kafka containers with
make dev.up.kafka-control-centerIn order to test this change, you will need to generate a certificate for a user in a verified seat in a course that is part of a program. There are a few different ways to do this. Using a clean devstack, the way I found was:
frontend-app-support-tools(outside of devstack)./manage.py lms cache_programsto populate the programs cacheOnce you have a certificate and user set up, to actually test the event:
TopicsGradingsection in studio and adjust the grading scale by adding or removing grades../manage.py lms compute_grades --courses 'course-v1:edX+DemoX+Demo_Course' --settings=devstackcredentials_grade_changeshould appear as a new topiccredentials_grade_changetopic and go to theMessagestab. Then update the studio grading and rerun the management command. A new message should appear. Make sure you open the Messages tab first, since that page only shows messages produced since you opened it.Deadline
None