feat: New codemods on OpenedX 1 (#28776)#29561
feat: New codemods on OpenedX 1 (#28776)#29561edx-community-bot merged 1 commit intoopenedx:open-release/maple.masterfrom
Conversation
|
Thanks for the pull request, @cmltaWt0! I've created OSPR-6270 to keep track of it in JIRA. As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion. |
openedx-webhooks
added
core committer
open-source-contribution
edx-community-bot
left a comment
edx-community-bot
left a comment
There was a problem hiding this comment.
👍
When you're ready to merge, add a comment that says
@edx-community-bot merge
and we'll handle the rest!
CC: @edx/community-engineering @edx/open-release-maintainers
There was a problem hiding this comment.
Hello @cmltaWt0! Changes look good to me 👍🏼
I do have a single nitpick, however.
In the pull request description, you mentioned the commit edx@5cd961d. However, when I open the commit it shows the following warning:
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Would you mind including the merged commit hash, edx@39b9115, instead?
Regarding the failed migrations check, I looked at it and it isn't caused by any changes in this pull request.
The same migrations check seems to be failing for some and succeeding for others, it might possibly be resolved by re-running the migrations check.
|
@nizarmah That's true. I've included original commit instead of merge commit. Going to fix it. |
cmltaWt0
force-pushed
the
cmltaWt0/codemods-openedx-1
branch
from
876987f to
fe7e97e
Compare
cmltaWt0
changed the title
cmltaWt0
force-pushed
the
cmltaWt0/codemods-openedx-1
branch
from
fe7e97e to
201d4f0
Compare
cmltaWt0
changed the title
|
@nizarmah PR has been updated with merge commit instead of detached one. |
|
@edx-community-bot merge |
openedx-webhooks
added
merged
and removed
waiting on author
|
@jmbowman: thought you might like to know that cmltaWt0 merged this pull request. |
|
@cmltaWt0 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Thank you all! |
5 participants
Description
cherry-picked 39b9115 from master branch to make changes availabe in maple release.
Supporting information
Relevant JIRA : https://openedx.atlassian.net/browse/BOM-2781
BTR issue: openedx/wg-build-test-release#105