Skip to content

feat: New codemods on CMS (#28768)#29567

Merged
edx-community-bot merged 1 commit intoopenedx:open-release/maple.masterfrom
cmltaWt0:cmltaWt0/codemods-django-cms
Dec 15, 2021
Merged

feat: New codemods on CMS (#28768)#29567
edx-community-bot merged 1 commit intoopenedx:open-release/maple.masterfrom
cmltaWt0:cmltaWt0/codemods-django-cms

Conversation

@cmltaWt0
Copy link
Contributor

@cmltaWt0 cmltaWt0 commented Dec 13, 2021

Description

cherry-picked e54fb5f from master branch to make changes available in maple release.

Supporting information

Relevant JIRA : https://openedx.atlassian.net/browse/BOM-2781
BTR issue: openedx/wg-build-test-release#105

@openedx-webhooks
Copy link

Thanks for the pull request, @cmltaWt0! I've created OSPR-6275 to keep track of it in JIRA.

As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion.

@openedx-webhooks openedx-webhooks added core committer open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Dec 13, 2021
Copy link

@edx-community-bot edx-community-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

When you're ready to merge, add a comment that says

@edx-community-bot merge

and we'll handle the rest!
CC: @edx/community-engineering @edx/open-release-maintainers

Copy link
Contributor

@nizarmah nizarmah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cmltaWt0! Changes look good to me 👍🏼


Regarding the failed migrations check, I looked at it and it isn't caused by any changes in this pull request.
The same migrations check seems to be failing for some and succeeding for others, it might possibly be resolved by re-running the migrations check.

@cmltaWt0
Copy link
Contributor Author

@edx-community-bot merge

@edx-community-bot edx-community-bot merged commit 75c73f4 into openedx:open-release/maple.master Dec 15, 2021
@openedx-webhooks
Copy link

@jmbowman: thought you might like to know that cmltaWt0 merged this pull request.

@openedx-webhooks openedx-webhooks added merged and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Dec 15, 2021
@openedx-webhooks
Copy link

@cmltaWt0 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants