Skip to content

style: code cleanups from Steven Burch (#29292)#29651

Merged
edx-community-bot merged 1 commit intoopenedx:open-release/maple.masterfrom
cmltaWt0:cmltaWt0/code_cleanup
Dec 23, 2021
Merged

style: code cleanups from Steven Burch (#29292)#29651
edx-community-bot merged 1 commit intoopenedx:open-release/maple.masterfrom
cmltaWt0:cmltaWt0/code_cleanup

Conversation

@cmltaWt0
Copy link
Contributor

Description

cherry-picked d9dd10d from master branch to make changes availabe in maple release.

Supporting information

BTR issue: openedx/wg-build-test-release#105

@cmltaWt0 cmltaWt0 requested a review from a team December 20, 2021 20:46
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 20, 2021

Thanks for the pull request, @cmltaWt0! I've created OSPR-6331 to keep track of it in JIRA.

As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion.

Copy link

@edx-community-bot edx-community-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

When you're ready to merge, add a comment that says

@edx-community-bot merge

and we'll handle the rest!
CC: @edx/community-engineering @edx/open-release-maintainers

* chore: update deprecated import from collections

* chore: remove outdated imports from markdown library

as it hasn't been supported since 2.0.3 and we're on 3.x.
This was deprecated at least as early as 2012!

* docs: add docstring and remove lint-amnesty to markdown plugin

* chore: remove deprecated etree import

* style: remove unnecessary-comprehension for sets

* style: resolve a number of amnestied pylint complaints

Co-authored-by: stvn <stvn@mit.edu>
@cmltaWt0 cmltaWt0 force-pushed the cmltaWt0/code_cleanup branch from 6620b4c to c541989 Compare December 22, 2021 13:27
@natabene
Copy link
Contributor

@cmltaWt0 Thank you for your contribution.

@cmltaWt0
Copy link
Contributor Author

@edx-community-bot merge

@edx-community-bot edx-community-bot merged commit d2be50f into openedx:open-release/maple.master Dec 23, 2021
@openedx-webhooks
Copy link

@jmbowman: thought you might like to know that cmltaWt0 merged this pull request.

@openedx-webhooks
Copy link

@cmltaWt0 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants