Skip to content

feat: hide Old Mongo courses from catalog #29945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikix merged 1 commit into from
Feb 17, 2022
Merged

feat: hide Old Mongo courses from catalog #29945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lms/djangoapps/course_api/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def get_hidden(self, course_overview):
Represents whether course is hidden in LMS
"""
catalog_visibility = course_overview.catalog_visibility
return catalog_visibility in ['about', 'none']
return catalog_visibility in ['about', 'none'] or course_overview.id.deprecated # Old Mongo should be hidden

def get_blocks_url(self, course_overview):
"""
Expand Down
2 changes: 1 addition & 1 deletion lms/djangoapps/course_api/tests/test_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def setUp(self):
'effort': '6 hours',
'pacing': 'instructor',
'mobile_available': True,
'hidden': False,
'hidden': True, # because it's an old mongo course
'invitation_only': False,

# 'course_id' is a deprecated field, please use 'id' instead.
Expand Down