-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: get CELERY_RESULT_BACKEND from ENV_TOKENS #30245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get CELERY_RESULT_BACKEND from ENV_TOKENS #30245
Conversation
|
Thanks for the pull request, @navinkarkera! I've created OSPR-6619 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@navinkarkera Thank you for your contribution. Is this ready for our review? |
|
Hi @natabene ! This is not ready for your review yet. I'll ping you here once ready. |
kaustavb12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks good to me
- I tested this: Tested in PR Sandbox
- I read through the code
|
Thank you for your patience here. This PR is now ready for your review. |
|
@BbrSofiane Please merge whenever you have a chance. |
|
@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Merged as requested on https://openedx.slack.com/archives/C015KC8CN76/p1654701668100529 |
Description
Cherry pick of #30244
At Opencraft, we want to run multiple instances of celery workers in separate servers. The celery workers need to be able to share task results. Currently, the
CELERY_RESULT_BACKENDis hard coded to usedjango-cache.So this PR allows to setup
CELERY_RESULT_BACKENDvia configuration.To use django ORM as celery backend, one can set
CELERY_RESULT_BACKENDtodjango-dbas described in docs.Supporting information
Deadline
"None"