Skip to content

fix: get CELERY_RESULT_BACKEND from ENV_TOKENS#30246

Merged
giovannicimolin merged 1 commit intoopenedx:open-release/maple.masterfrom
open-craft:navin/fix-celery-backend-maple
Jun 15, 2022
Merged

fix: get CELERY_RESULT_BACKEND from ENV_TOKENS#30246
giovannicimolin merged 1 commit intoopenedx:open-release/maple.masterfrom
open-craft:navin/fix-celery-backend-maple

Conversation

@navinkarkera
Copy link
Contributor

Description

Cherry pick of #30244

At Opencraft, we want to run multiple instances of celery workers in separate servers. The celery workers need to be able to share task results. Currently, the CELERY_RESULT_BACKEND is hard coded to use django-cache.

So this PR allows to setup CELERY_RESULT_BACKEND via configuration.

To use django ORM as celery backend, one can set CELERY_RESULT_BACKEND to django-db as described in docs.

Supporting information

Deadline

"None"

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Apr 14, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @navinkarkera! I've created OSPR-6620 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@natabene
Copy link
Contributor

natabene commented Apr 26, 2022

@navinkarkera Thank you for your contribution. Is this ready for our review?

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Apr 26, 2022
@kaustavb12
Copy link
Contributor

Hi @natabene !

This is not ready for your review yet. I'll ping you here once ready.

Copy link
Contributor

@kaustavb12 kaustavb12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good to me

  • I tested this: Tested in PR Sandbox
  • I read through the code

@kaustavb12
Copy link
Contributor

kaustavb12 commented May 22, 2022

@natabene

Thank you for your patience here. This PR is now ready for your review.

@navinkarkera navinkarkera force-pushed the navin/fix-celery-backend-maple branch from ffb008e to 257c54d Compare June 10, 2022 13:25
Copy link
Contributor

@giovannicimolin giovannicimolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-pick of #30244.

👍

  • I tested this:
  1. Checked that the default value retains previous behavior.
  2. Checked that changing the variable allows configuring a different result backend for celery (verified it's working on a client instance)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation: comment on code.

@giovannicimolin giovannicimolin merged commit 3cf7e10 into openedx:open-release/maple.master Jun 15, 2022
@openedx-webhooks openedx-webhooks removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jun 15, 2022
@openedx-webhooks
Copy link

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Agrendalath Agrendalath deleted the navin/fix-celery-backend-maple branch September 27, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants