fix: get CELERY_RESULT_BACKEND from ENV_TOKENS#30246
Conversation
|
Thanks for the pull request, @navinkarkera! I've created OSPR-6620 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@navinkarkera Thank you for your contribution. Is this ready for our review? |
|
Hi @natabene ! This is not ready for your review yet. I'll ping you here once ready. |
kaustavb12
left a comment
There was a problem hiding this comment.
👍
Looks good to me
- I tested this: Tested in PR Sandbox
- I read through the code
|
Thank you for your patience here. This PR is now ready for your review. |
ffb008e to
257c54d
Compare
giovannicimolin
left a comment
There was a problem hiding this comment.
Cherry-pick of #30244.
👍
- I tested this:
- Checked that the default value retains previous behavior.
- Checked that changing the variable allows configuring a different result backend for celery (verified it's working on a client instance)
- I read through the code
- I checked for accessibility issues
- Includes documentation: comment on code.
|
@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Cherry pick of #30244
At Opencraft, we want to run multiple instances of celery workers in separate servers. The celery workers need to be able to share task results. Currently, the
CELERY_RESULT_BACKENDis hard coded to usedjango-cache.So this PR allows to setup
CELERY_RESULT_BACKENDvia configuration.To use django ORM as celery backend, one can set
CELERY_RESULT_BACKENDtodjango-dbas described in docs.Supporting information
Deadline
"None"