Skip to content

Update Docker Image to use node 16#30459

Merged
aht007 merged 3 commits intoopen-release/nutmeg.masterfrom
aht007/Update-Docker-Node
May 24, 2022
Merged

Update Docker Image to use node 16#30459
aht007 merged 3 commits intoopen-release/nutmeg.masterfrom
aht007/Update-Docker-Node

Conversation

@aht007
Copy link
Contributor

@aht007 aht007 commented May 23, 2022 •
edited
Loading

This PR is a follow up PR for Node Upgrade and updates the Node version in Dockerfile to version 16

@aht007 aht007 merged commit 489ed46 into open-release/nutmeg.master May 24, 2022
@aht007 aht007 deleted the aht007/Update-Docker-Node branch May 24, 2022 09:44
@regisb
Copy link
Contributor

regisb commented May 24, 2022 •
edited
Loading

Wait why was this merged in Nutmeg? This is breaking the build of the Nutmeg branch, just like #30420 is breaking nightly.

EDIT: for more information check my comment here: #30420 (comment)

@aht007
Copy link
Contributor Author

aht007 commented May 25, 2022

@regisb
This PR is already on production on our side and doesn't break anything. Also this PR does nothing except updating the Dockerfile to use Node16. Also according to SRE this Dockerfile is not used for any purposes right now and images are built from Jenkins Job and pushed to edxops. Why would this break anything on the Nutmeg branch? Also it was supposed to be merged since we are moving to Node16 for Nutmeg

@regisb
Copy link
Contributor

regisb commented May 25, 2022

@aht007 I'm talking on behalf of the rest of the community who uses Tutor to run Open edX. I was referring to the Docker image built by Tutor. It breaks Tutor because it does not allow us to run "npm ci" and install pinned dependencies. And yes we do need the upgrade to Node 16 but we need a fully functional implementation.
Please see the other conversations on the same topic:
#30420 (comment)
https://openedx.slack.com/archives/C01AGTSB1LL/p1653409070765259?thread_ts=1653409070.765259&cid=C01AGTSB1LL

@aht007
Copy link
Contributor Author

aht007 commented May 25, 2022

Ahh I see, From the conversation it looks like we have consensus for reverting back to Node12 for Nutmeg release.
I will discuss with @jmbowman about our way forward

@regisb
Copy link
Contributor

regisb commented May 25, 2022

Awesome, thanks a bunch.

aht007 added a commit that referenced this pull request May 25, 2022
@aht007
Revert "chore: update Docker Image to use node 16 (#30459)"
2344198 
This reverts commit 489ed46.
@aht007 aht007 mentioned this pull request May 25, 2022
Merged
aht007 added a commit that referenced this pull request May 25, 2022
@aht007
Revert "chore: update Docker Image to use node 16 (#30459)" (#30478)
61793b8 
This reverts commit 489ed46.
dmitry-viskov pushed a commit to weaveeducation/edx-platform that referenced this pull request May 27, 2022
@aht007
chore: update Docker Image to use node 16 (openedx#30459)
cad54f1
dmitry-viskov pushed a commit to weaveeducation/edx-platform that referenced this pull request May 27, 2022
@aht007
Revert "chore: update Docker Image to use node 16 (openedx#30459)" (o…
6b6f92d 
…penedx#30478)

This reverts commit 489ed46.
regisb added a commit to overhangio/tutor that referenced this pull request Jun 3, 2022
@regisb
fix: revert back to "npm install"
5faf03e 
"npm ci" is broken in master because of the node 16 upgrade. See discussion
here:
openedx/openedx-platform#30459 (comment)

We will revert to "npm ci" once the node 16 upgrade is complete.
sambapete pushed a commit to EDUlib/edx-platform that referenced this pull request Oct 12, 2022
@aht007 @sambapete
Revert "chore: update Docker Image to use node 16 (openedx#30459)" (o…
39d63b4 
…penedx#30478)

This reverts commit 489ed46.
sambapete pushed a commit to EDUlib/edx-platform that referenced this pull request Dec 13, 2022
@aht007 @sambapete
Revert "chore: update Docker Image to use node 16 (openedx#30459)" (o…
b18ad25 
…penedx#30478)

This reverts commit 489ed46.
jcohen28 pushed a commit to Medality-Health/edx-platform that referenced this pull request Dec 18, 2022
@aht007 @jcohen28
Revert "chore: update Docker Image to use node 16 (openedx#30459)" (o…
6e71e2b 
…penedx#30478)

This reverts commit 489ed46.
sambapete pushed a commit to EDUlib/edx-platform that referenced this pull request Feb 9, 2023
@aht007 @sambapete
Revert "chore: update Docker Image to use node 16 (openedx#30459)" (o…
e0ecb5a 
…penedx#30478)

This reverts commit 489ed46.
sambapete pushed a commit to EDUlib/edx-platform that referenced this pull request Apr 11, 2023
@aht007 @sambapete
Revert "chore: update Docker Image to use node 16 (openedx#30459)" (o…
90f2942 
…penedx#30478)

This reverts commit 489ed46.
sambapete pushed a commit to EDUlib/edx-platform that referenced this pull request May 22, 2023
@aht007 @sambapete
Revert "chore: update Docker Image to use node 16 (openedx#30459)" (o…
7e387e5 
…penedx#30478)

This reverts commit 489ed46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UsamaSadiq UsamaSadiq UsamaSadiq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aht007 @regisb @UsamaSadiq