fix: cross-site scripting vulnerability on logout page#30544
Merged
waheedahmed merged 1 commit intoopen-release/nutmeg.masterfrom Jun 6, 2022
Merged
Conversation
The target URL on logout page is marked as safe while rendering and making the page volunerable to Cross-site scripting vulnerability. Rendered the target variable outside safe HTML so that it should be treated as text. VAN-972
Contributor
Author
|
Hi @nedbat, this is a backport PR for a security fix against |
nedbat
approved these changes
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The target URL on logout page is marked as safe while rendering and making the page volunerable to Cross-site scripting vulnerability.
Rendered the target variable outside safe HTML so that it should be treated as text.
VAN-972
Private repo PR: https://github.com/edx/edx-platform-private/pull/250