fix: section.due datetime version issue#30848
Conversation
xmodule/block_metadata_utils.py
Outdated
There was a problem hiding this comment.
It looks like this is mostly copy/pasted from https://github.com/openedx/edx-platform/blob/3492bede446e4523ee09f965b7639b55af0472d0/openedx/core/djangoapps/content/block_structure/block_structure.py#L453-L483, is there a reason to redefine this instead of importing or using that function?
There was a problem hiding this comment.
looks like this is moving that part for reuse in block_structure and here, but maybe it could just use get_xblock_field directly as you say
There was a problem hiding this comment.
How do I re-use it? self.due = subsection.get_xblock_field('due')?
There was a problem hiding this comment.
Doing a quick repo search shows some examples. If I had to guess:
self.get_xblock_field(usage_key, "due")
There was a problem hiding this comment.
neither self and subsection was a subclass of BlockStructureBlockData.
There was a problem hiding this comment.
After a discussion, decided that these are slightly different use-cases so it's okay to have a duplication, but should comment so it's clear that if one function changes both will probably have to change.
leangseu-edx
force-pushed
the
leangseu-edx/section-due-date-fix
branch
from
c446410 to
0155a0a
Compare
leangseu-edx
force-pushed
the
leangseu-edx/section-due-date-fix
branch
from
0155a0a to
86fdfbd
Compare
leangseu-edx
force-pushed
the
leangseu-edx/section-due-date-fix
branch
from
86fdfbd to
e25dfe7
Compare
ashultz0
left a comment
ashultz0
left a comment
There was a problem hiding this comment.
not really authoritative for Aurora tickets but this is the sort of fix that I was expecting and you've discussed the details so 👍
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
4 participants
Ticket: AU-782
Description
There seems to be issue with datetime version compatibilities especially if the datetime data being stored in Cache. It is a wack a mole situation at the moment.
Reference:
https://openedx.atlassian.net/browse/BOM-2245
fix: python-dateutil version issue #30530
BOM-2245 : Unpin python-dateutil #30255