[OldMongo FC-0004] Tests for removing support for children in Old Mongo - part 1#31422
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
UvgenGen
force-pushed
the
sagirov/EDXOLDMNG-192-part1
branch
5 times, most recently
from
0752478 to
a45d990
Compare
ormsbee
left a comment
ormsbee
left a comment
There was a problem hiding this comment.
A couple of minor questions. Thank you1
There was a problem hiding this comment.
Isn't the purpose of the test to see if it saved properly and could be read back?
xmodule/modulestore/tests/utils.py
Outdated
There was a problem hiding this comment.
Can you please explain in the commit message why this was change was necessary?
There was a problem hiding this comment.
When using parent_location instead of parent I get an error related with children/parent problem for split modulestore. Looking at other tests using split modulestore - parent argument is used only. I'll add it to commit message later.
ormsbee
left a comment
ormsbee
left a comment
There was a problem hiding this comment.
Please squash changes and add context to the commit message. Thank you.
* fixed problem with creating some CourseItem with some parent: we must get the updated parent item before using that parent item * replaced parent_location with parent argument in ItemFactory due to error children/parent relation for split modulestore. In all tests with split modulestore parent argument used
UvgenGen
force-pushed
the
sagirov/EDXOLDMNG-192-part1
branch
from
7676560 to
8ad9ac6
Compare
|
@ormsbee PR squashed and rebased, commit message updated) |
|
@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
|
EdX Release Notice: This PR has been deployed to the production environment. |
5 participants
Description
First part of preparing tests for
Remove support for children in Old Mongotask (#31134).Fixed problem with .get_children() in tests for split modulestore.
Problem: If we create some CourseItem with some parent, we must get the updated parent item before using that parent item.
Useful information to include:
Remove support for children in Old Mongo PR: #31134
openedx/public-engineering#80