Skip to content

enhancement: add support for caching programs for one site #32380

Merged
ziafazal merged 10 commits intoopenedx:masterfrom
edly-io:enhancement/faraz-add_support_for_caching_programs_for_one_site
Jun 15, 2023
Merged

enhancement: add support for caching programs for one site #32380
ziafazal merged 10 commits intoopenedx:masterfrom
edly-io:enhancement/faraz-add_support_for_caching_programs_for_one_site

Conversation

@Faraz32123
Copy link
Contributor

@Faraz32123 Faraz32123 commented Jun 6, 2023

This PR is created as a fix for this issue of tutor-discovery plugin.

When a user runs a command(tutor local run lms ./manage.py lms cache_programs) for caching programs to their LMS from Discovery, it always fails and shows an error because this command tries to cache programs from multiple sites and LMS is unable to cache programs for development site when running tutor in local environment or vice versa.

With this enhancement, user can now add an option --domain=site_domain_name to the above command i.e. pass local site domain name to --domain option when running tutor in local environment or pass development site domain name to --domain option when running tutor in development environment. As a result no error will occur as this command will cache programs for one site that is given to --domain option to the command.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 6, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @Faraz32123! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@regisb
Copy link
Contributor

regisb commented Jun 6, 2023

For the record, this PR was opened following this issue: overhangio/tutor-discovery#40

@Faraz32123 you should probably update the PR description.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 7, 2023
@mphilbrick211
Copy link

Hi @Faraz32123! Thanks for this contribution. Please let me know if you have any questions regarding submitting your CLA form. Thanks!

@e0d e0d changed the title enhancement: add support for caching programs for one site enhancement: add support for caching programs for one site Jun 7, 2023
@e0d
Copy link
Contributor

e0d commented Jun 7, 2023

I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 7, 2023
@Faraz32123 Faraz32123 force-pushed the enhancement/faraz-add_support_for_caching_programs_for_one_site branch from f91ea92 to 600bc02 Compare June 8, 2023 06:43
@Faraz32123 Faraz32123 force-pushed the enhancement/faraz-add_support_for_caching_programs_for_one_site branch from 154be4d to 7ec2caa Compare June 8, 2023 11:52
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 8, 2023
@Faraz32123 Faraz32123 force-pushed the enhancement/faraz-add_support_for_caching_programs_for_one_site branch from e152ab9 to d23c0d7 Compare June 9, 2023 15:11
@Faraz32123 Faraz32123 force-pushed the enhancement/faraz-add_support_for_caching_programs_for_one_site branch from e9a0b35 to f68b19f Compare June 12, 2023 07:03
@ziafazal
Copy link
Contributor

@mphilbrick211 can I assign it to myself as reviewer?

@e0d e0d requested a review from ziafazal June 12, 2023 15:42
@Faraz32123 Faraz32123 force-pushed the enhancement/faraz-add_support_for_caching_programs_for_one_site branch from 1c50928 to 11843da Compare June 13, 2023 09:15
@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 13, 2023
Copy link
Contributor

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ziafazal ziafazal merged commit 6568785 into openedx:master Jun 15, 2023
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Faraz32123 added a commit to edly-io/edx-platform that referenced this pull request Jun 19, 2023
…2380)

* perf!: add support for caching programs on per site bases
ziafazal pushed a commit that referenced this pull request Jun 20, 2023
…32506)

* perf!: add support for caching programs on per site bases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants