feat: redirect to custom URL when third-party auth account is unlinked#33513
Closed
ArturGaspar wants to merge 1 commit intoopenedx:masterfrom
Closed
feat: redirect to custom URL when third-party auth account is unlinked#33513ArturGaspar wants to merge 1 commit intoopenedx:masterfrom
ArturGaspar wants to merge 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
|
@ArturGaspar Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow redirecting to a custom URL when signing in via third-party auth when the account is not linked.
Testing instructions
TODO
Deadline
None
Other information
Alternate implementation of openedx/frontend-app-authn#1078
This does not have the problem where the login page briefly shows until third-party auth context is loaded, but has one big flaw which is that the user is still able to go to http://localhost:1999/login and see the error message.