Skip to content

Conversation

@bradenmacdonald
Copy link
Contributor

@bradenmacdonald bradenmacdonald commented Nov 2, 2023

Description

This updates our openedx-learning repo to the latest version, which includes some improvements to the REST API for "get object tags". (An unstable API that isn't yet used in prod by anyone.)

Supporting information

See openedx/openedx-learning#111 and openedx/modular-learning#133

Testing instructions

For now, it's sufficient to run the test suite.

Deadline

None

Other information

This will simplify #33563

Private ref: FAL-3547

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 2, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bradenmacdonald bradenmacdonald added FC Relates to an Axim Funded Contribution project and removed open-source-contribution PR author is not from Axim or 2U labels Nov 2, 2023
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 2, 2023
@bradenmacdonald
Copy link
Contributor Author

@yusuf-musleh FYI, the improvements to "get object tags" are ready and you can use them if you merge this branch into yours.

@bradenmacdonald
Copy link
Contributor Author

bradenmacdonald commented Nov 2, 2023

@pomegranited could you please review this before I ask for a platform CC to review?

@yusuf-musleh
Copy link
Member

@yusuf-musleh FYI, the improvements to "get object tags" are ready and you can use them if you merge this branch into yours.

@bradenmacdonald Awesome, thanks! I'll work on integrating it.

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

  • I didn't test this -- tests passing is enough.
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • I made sure any change in configuration variables is reflected in the corresponding
    client's configuration-secure repository.
    N/A

Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the tests are passing
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a

@bradenmacdonald bradenmacdonald merged commit 32bb4c5 into openedx:master Nov 6, 2023
@bradenmacdonald bradenmacdonald deleted the braden/update-object-tags-api branch November 6, 2023 19:54
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants