-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update openedx-learning, new format for the "get object tags" REST API (unstable) [FC-0036] #33651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update openedx-learning, new format for the "get object tags" REST API (unstable) [FC-0036] #33651
Conversation
|
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@yusuf-musleh FYI, the improvements to "get object tags" are ready and you can use them if you merge this branch into yours. |
|
@pomegranited could you please review this before I ask for a platform CC to review? |
@bradenmacdonald Awesome, thanks! I'll work on integrating it. |
pomegranited
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
- I didn't test this -- tests passing is enough.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
I made sure any change in configuration variables is reflected in the correspondingN/A
client'sconfiguration-securerepository.
Agrendalath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: checked that the tests are passing
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
|
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Description
This updates our
openedx-learningrepo to the latest version, which includes some improvements to the REST API for "get object tags". (An unstable API that isn't yet used in prod by anyone.)Supporting information
See openedx/openedx-learning#111 and openedx/modular-learning#133
Testing instructions
For now, it's sufficient to run the test suite.
Deadline
None
Other information
This will simplify #33563
Private ref: FAL-3547