fix: course progress url based on whether the user has learning MFE enabled (for master) by FatemeKhodayari · Pull Request #34344 · openedx/openedx-platform

FatemeKhodayari · 2024-03-09T09:26:36Z

Currently, as we have in Quince, when a user hasn't passed the course, the "View Grades" link / button is displayed to him on the dashboard. Clicking on this link / button, takes the user to the old progress page. The URL of the old progress page is returned in the /api/learner_home/init response. In this change, course progress URL is returned based on whether the user has learning MFE enabled or not.

This issue was originally created in this forum topic and later discussed a little bit in the Maintenance WG meeting.

Closes #34323

openedx-webhooks · 2024-03-09T09:26:41Z

Thanks for the pull request, @FatemeKhodayari! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx/features/course_experience/__init__.py

feanil

@FatemeKhodayari changes look good to me, can you add a test case to validate the change also, then I think this looks good to merge.

justinhynes · 2024-03-26T17:51:49Z

Hi there -- just mentioning that this is on our radar too for review. I should be able to take a look shortly.

FatemeKhodayari · 2024-03-27T08:58:57Z

@FatemeKhodayari changes look good to me, can you add a test case to validate the change also, then I think this looks good to merge.

Sure! I'll try to add the test by Saturday.

FatemeKhodayari · 2024-03-30T13:52:20Z

Hi @feanil! Just added the test. Please let me know if anything needs changing.

lms/djangoapps/learner_home/test_serializers.py

FatemeKhodayari · 2024-05-08T07:13:16Z

Hi @feanil. Could you please have a look at this when possible? I last updated this repo about 3 week ago. Thanks in advance :)

feanil

A couple of final comments then this is good to merge. Soooo sorry for the slow review, the Python 3.11 upgrade ate up all my time.

lms/djangoapps/learner_home/test_utils.py

…ab_is_active

feanil · 2024-07-15T21:07:04Z

Looks great, I'll coordinate merging this tomorrow.

openedx-webhooks · 2024-07-16T18:53:56Z

@FatemeKhodayari 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

edx-pipeline-bot · 2024-07-16T20:23:48Z

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot · 2024-07-17T14:49:23Z

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot · 2024-07-17T14:49:24Z

2U Release Notice: This PR has been deployed to the edX production environment.

FatemeKhodayari requested a review from a team as a code owner March 9, 2024 09:26

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 9, 2024

feanil requested changes Mar 11, 2024

View reviewed changes

openedx/features/course_experience/__init__.py Outdated Show resolved Hide resolved

mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 11, 2024

FatemeKhodayari force-pushed the fix/course-progress-page-url-for-master branch from d564408 to 64653f3 Compare March 12, 2024 05:41

FatemeKhodayari requested a review from feanil March 13, 2024 13:37

mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 13, 2024

FatemeKhodayari mentioned this pull request Mar 16, 2024

fix: course progress url based on whether the user has learning MFE enabled (for Quince) #34343

Merged

jsnwesson added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Mar 18, 2024

feanil reviewed Mar 19, 2024

View reviewed changes

openedx/features/course_experience/__init__.py Outdated Show resolved Hide resolved

FatemeKhodayari force-pushed the fix/course-progress-page-url-for-master branch 2 times, most recently from 7caba09 to 395085e Compare March 21, 2024 11:31

feanil reviewed Mar 26, 2024

View reviewed changes

FatemeKhodayari force-pushed the fix/course-progress-page-url-for-master branch from 395085e to 8a1deb1 Compare March 30, 2024 13:46

FatemeKhodayari requested a review from feanil March 30, 2024 13:51

FatemeKhodayari force-pushed the fix/course-progress-page-url-for-master branch from 8a1deb1 to fad574f Compare March 31, 2024 02:01

feanil reviewed Apr 8, 2024

View reviewed changes

lms/djangoapps/learner_home/test_serializers.py Outdated Show resolved Hide resolved

deborahgu added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 10, 2024

FatemeKhodayari force-pushed the fix/course-progress-page-url-for-master branch from fad574f to 5ceb5f1 Compare April 15, 2024 16:46

FatemeKhodayari requested a review from feanil April 15, 2024 16:47

feanil reviewed May 9, 2024

View reviewed changes

lms/djangoapps/learner_home/test_utils.py Outdated Show resolved Hide resolved

lms/djangoapps/learner_home/test_utils.py Outdated Show resolved Hide resolved

fix: course progress url returned based on course_home_mfe_progress_t…

a5359d2

…ab_is_active

FatemeKhodayari force-pushed the fix/course-progress-page-url-for-master branch from 5ceb5f1 to a5359d2 Compare June 28, 2024 12:33

FatemeKhodayari requested a review from feanil July 3, 2024 09:19

deborahgu removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 9, 2024

feanil approved these changes Jul 15, 2024

View reviewed changes

feanil merged commit 8b1e647 into openedx:master Jul 16, 2024

itsjeyd removed the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Sep 7, 2024

Conversation

FatemeKhodayari commented Mar 9, 2024

Uh oh!

openedx-webhooks commented Mar 9, 2024

Uh oh!

Uh oh!

Uh oh!

feanil left a comment

Choose a reason for hiding this comment

Uh oh!

justinhynes commented Mar 26, 2024

Uh oh!

FatemeKhodayari commented Mar 27, 2024

Uh oh!

FatemeKhodayari commented Mar 30, 2024

Uh oh!

Uh oh!

FatemeKhodayari commented May 8, 2024

Uh oh!

feanil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

feanil commented Jul 15, 2024

Uh oh!

openedx-webhooks commented Jul 16, 2024

Uh oh!

edx-pipeline-bot commented Jul 16, 2024

Uh oh!

edx-pipeline-bot commented Jul 17, 2024

Uh oh!

edx-pipeline-bot commented Jul 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants