refactor: switch from mock to unittest.mock#34844
Merged
kdmccormick merged 1 commit intoopenedx:masterfrom May 22, 2024
Merged
Conversation
As of Python 3.3, the 3rd-party 'mock' package has been subsumed into the standard 'unittest.mock' package. Refactoring tests to use the latter will allow us to drop 'mock' as a dependency, which is currently coming in transitively through paver.in.
This was referenced May 22, 2024
Closed
feanil
approved these changes
May 22, 2024
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Python 3.3, the 3rd-party
mockpackage has been subsumed into the standardunittest.mockpackage. Refactoring tests to use the latter will allow us to dropmockas a dependency, which is currently coming in transitively through requirements/edx/paver.in.We don't actually drop the
mockdependency in this PR. That will happen naturally in: