test: run content_libraries runtime tests#35531
Closed
kdmccormick wants to merge 1 commit intoopenedx:masterfrom
Closed
test: run content_libraries runtime tests#35531kdmccormick wants to merge 1 commit intoopenedx:masterfrom
kdmccormick wants to merge 1 commit intoopenedx:masterfrom
Conversation
Member
Author
|
Things that are breaking:
|
20ada9f to
c298ce6
Compare
Contributor
|
@kdmccormick We don't need to support |
Contributor
|
@kdmccormick Do you want help with this, or are you planning to finish it up? We can definitely take it on if you'd like. |
Member
Author
|
I had no immediate plans to work on it, so by all means feel free to take it over! |
Member
Author
|
Closed in favor of #35783 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Somewhere in the series of refactorings that this app has undergone, it seems that we removed TestCase from the inheritance tree of the tests in openedx/core/djangoapps/content_libraries/tests/test_runtime.py, effectively skipping the test cases.
This PR turns them back into tests. TODO: Fix the test failures.
Testing instructions
Check the logs of
openedx-1-with-lmsandopenedx-2-with-cmsto confirm that test_runtime is executing.Deadline
Sooner better than later
Other information
This could have been avoided if we had: