Skip to content

Re-enable content libraries runtime tests [FC-0062] #35783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navinkarkera merged 4 commits into from
Nov 7, 2024
Merged

Re-enable content libraries runtime tests [FC-0062] #35783

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c298ce6
test: run content_libraries runtime tests
kdmccormick Sep 24, 2024
4a8ca96
Merge remote-tracking branch 'origin/master' into jill/kdmccormick/te…
pomegranited Nov 6, 2024
42bd203
test: fix broken tests
pomegranited Nov 6, 2024
664f3f7
test: fix lms tests
pomegranited Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 19 additions & 20 deletions openedx/core/djangoapps/content_libraries/tests/test_runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
Test the Learning-Core-based XBlock runtime and content libraries together.
"""
import json
from gettext import GNUTranslations
from django.test import TestCase

from completion.test_utils import CompletionWaffleTestMixin
from django.db import connections, transaction
from django.test import TestCase, override_settings
from django.utils.text import slugify
import django.utils.translation
from organizations.models import Organization
from rest_framework.test import APIClient
from xblock.core import XBlock
Expand Down Expand Up @@ -140,18 +140,17 @@ def test_html_round_trip(self):
assert olx_3 == olx_2 == canonical_olx


class ContentLibraryRuntimeTests(ContentLibraryContentTestMixin):
class ContentLibraryRuntimeTests(ContentLibraryContentTestMixin, TestCase):
"""
Basic tests of the Learning-Core-based XBlock runtime using XBlocks in a
content library.
"""

def test_dndv2_sets_translator(self):
dnd_block_key = library_api.create_library_block(self.library.key, "drag-and-drop-v2", "dnd1").usage_key
library_api.publish_changes(self.library.key)
dnd_block = xblock_api.load_block(dnd_block_key, self.student_a)
i18n_service = dnd_block.runtime.service(dnd_block, 'i18n')
assert isinstance(i18n_service.translator, GNUTranslations)
assert i18n_service.translator is django.utils.translation

def test_has_score(self):
"""
Expand All @@ -169,8 +168,7 @@ def test_xblock_metadata(self):
"""
Test the XBlock metadata API
"""
unit_block_key = library_api.create_library_block(self.library.key, "unit", "metadata-u1").usage_key
problem_key = library_api.create_library_block_child(unit_block_key, "problem", "metadata-p1").usage_key
Copy link
Contributor Author

@pomegranited pomegranited Nov 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: There's no create_library_block_child method in the api anymore -- and LearningCoreXBlockRuntime doesn't support child blocks, so I've removed parent-child relationships from these tests.

problem_key = library_api.create_library_block(self.library.key, "problem", "metadata-p1").usage_key
new_olx = """
<problem display_name="New Multi Choice Question" max_attempts="5">
<multiplechoiceresponse>
Expand All @@ -192,14 +190,6 @@ def test_xblock_metadata(self):
client = APIClient()
client.login(username=self.student_a.username, password='edx')

# Check the metadata API for the unit:
metadata_view_result = client.get(
URL_BLOCK_METADATA_URL.format(block_key=unit_block_key),
{"include": "children,editable_children"},
)
assert metadata_view_result.data['children'] == [str(problem_key)]
assert metadata_view_result.data['editable_children'] == [str(problem_key)]

# Check the metadata API for the problem:
metadata_view_result = client.get(
URL_BLOCK_METADATA_URL.format(block_key=problem_key),
Expand All @@ -226,8 +216,7 @@ def test_xblock_fields(self):
client.login(username=self.staff_user.username, password='edx')

# create/save a block using the library APIs first
unit_block_key = library_api.create_library_block(self.library.key, "unit", "fields-u1").usage_key
block_key = library_api.create_library_block_child(unit_block_key, "html", "fields-p1").usage_key
block_key = library_api.create_library_block(self.library.key, "html", "fields-p1").usage_key
new_olx = """
<html display_name="New Text Block">
<p>This is some <strong>HTML</strong>.</p>
Expand All @@ -250,14 +239,24 @@ def test_xblock_fields(self):
}
}, format='json')
block_saved = xblock_api.load_block(block_key, self.staff_user)
assert block_saved.data == '\n<p>test</p>\n'
assert block_saved.data == '<p>test</p>'
assert block_saved.display_name == 'New Display Name'


# EphemeralKeyValueStore requires a working cache, and the default test cache is a dummy cache.
@override_settings(
XBLOCK_RUNTIME_V2_EPHEMERAL_DATA_CACHE='default',
CACHES={
'default': {
'BACKEND': 'django.core.cache.backends.locmem.LocMemCache',
'LOCATION': 'edx_loc_mem_cache',
},
},
)
# We can remove the line below to enable this in Studio once we implement a session-backed
# field data store which we can use for both studio users and anonymous users
@skip_unless_lms
class ContentLibraryXBlockUserStateTest(ContentLibraryContentTestMixin):
class ContentLibraryXBlockUserStateTest(ContentLibraryContentTestMixin, TestCase):
"""
Test that the Blockstore-based XBlock runtime can store and retrieve student
state for XBlocks when learners access blocks directly in a library context,
Expand Down Expand Up @@ -560,7 +559,7 @@ def test_i18n(self):


@skip_unless_lms # No completion tracking in Studio
class ContentLibraryXBlockCompletionTest(ContentLibraryContentTestMixin, CompletionWaffleTestMixin):
class ContentLibraryXBlockCompletionTest(ContentLibraryContentTestMixin, CompletionWaffleTestMixin, TestCase):
"""
Test that the Blockstore-based XBlocks can track their completion status
using the completion library.
Expand Down