fix: flag API positional arguments#35968
Closed
Faraz32123 wants to merge 2 commits intoopenedx:masterfrom
Closed
Conversation
To reproduce the error: - switch to mongodb from mysql for a specific course. - create a thread and report the thread. It'll throw an error due to wrong positioning of the arguments. So, this commit - uses keyword arguments in flag APIs - adds mock tests for code coverage
regisb
approved these changes
Dec 5, 2024
Contributor
regisb
left a comment
regisb
left a comment
There was a problem hiding this comment.
Nice job with the test coverage.
Contributor
Author
|
closing this PR in favor of this PR: #35933. I have added the commit there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue related to ForumV2 flag API. For details to know about ForumV2, got to this link https://github.com/openedx/forum/blob/master/README.rst. To reproduce the error:
So, this commit fixes the issue and