Skip to content

fix: Enable ORA new submissions course notification preference #36449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muhammadadeeltajamul merged 2 commits into from
Apr 10, 2025
Merged

fix: Enable ORA new submissions course notification preference #36449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bfdf93
fix: Enable ORA new submissions course notification preference
hassan-raza-1 Mar 26, 2025
cb2fc7d
fix: update edx-ora2 version
hassan-raza-1 Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions openedx/core/djangoapps/notifications/base_notification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,12 +191,12 @@
'email_template': '',
'filters': [FILTER_AUDIT_EXPIRED_USERS_WITH_NO_ROLE]
},
'ora_staff_notification': {
'ora_staff_notifications': {
'notification_app': 'grading',
'name': 'ora_staff_notification',
'name': 'ora_staff_notifications',
'is_core': False,
'info': '',
'web': False,
'web': True,
'email': False,
'push': False,
'email_cadence': EmailCadence.DAILY,
Expand Down
2 changes: 1 addition & 1 deletion openedx/core/djangoapps/notifications/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
ADDITIONAL_NOTIFICATION_CHANNEL_SETTINGS = ['email_cadence']

# Update this version when there is a change to any course specific notification type or app.
COURSE_NOTIFICATION_CONFIG_VERSION = 12
COURSE_NOTIFICATION_CONFIG_VERSION = 13


def get_course_notification_preference_config():
Expand Down
6 changes: 3 additions & 3 deletions openedx/core/djangoapps/notifications/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,8 @@ def _expected_api_response(self, course=None):
'enabled': True,
'core_notification_types': [],
'notification_types': {
'ora_staff_notification': {
'web': False,
'ora_staff_notifications': {
'web': True,
'email': False,
'push': False,
'email_cadence': 'Daily',
Expand Down Expand Up @@ -1088,7 +1088,7 @@ def setUp(self):
"email": True,
"email_cadence": "Daily"
},
"ora_staff_notification": {
"ora_staff_notifications": {
"web": False,
"push": False,
"email": False,
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,7 @@ openedx-mongodbproxy==0.2.2
# via -r requirements/edx/kernel.in
optimizely-sdk==5.2.0
# via -r requirements/edx/bundled.in
ora2==6.15.0
ora2==6.15.1
# via -r requirements/edx/bundled.in
packaging==24.2
# via
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/development.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,7 +1396,7 @@ optimizely-sdk==5.2.0
# via
# -r requirements/edx/doc.txt
# -r requirements/edx/testing.txt
ora2==6.15.0
ora2==6.15.1
# via
# -r requirements/edx/doc.txt
# -r requirements/edx/testing.txt
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/doc.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ openedx-mongodbproxy==0.2.2
# via -r requirements/edx/base.txt
optimizely-sdk==5.2.0
# via -r requirements/edx/base.txt
ora2==6.15.0
ora2==6.15.1
# via -r requirements/edx/base.txt
packaging==24.2
# via
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,7 +1058,7 @@ openedx-mongodbproxy==0.2.2
# via -r requirements/edx/base.txt
optimizely-sdk==5.2.0
# via -r requirements/edx/base.txt
ora2==6.15.0
ora2==6.15.1
# via -r requirements/edx/base.txt
packaging==24.2
# via
Expand Down
Loading