Skip to content

chore: update content libraries opaque key usages for opaque-keys v3#36588

Merged
bradenmacdonald merged 3 commits intoopenedx:masterfrom
open-craft:braden/opaque-keys-cleanup
Apr 23, 2025
Merged

chore: update content libraries opaque key usages for opaque-keys v3#36588
bradenmacdonald merged 3 commits intoopenedx:masterfrom
open-craft:braden/opaque-keys-cleanup

Conversation

@bradenmacdonald
Copy link
Contributor

This PR makes the corresponding changes for compatibility with openedx/opaque-keys#379

Not ready for merge: needs an opaque-keys version bump first.

@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link
Contributor

@ormsbee ormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the version bump, LGTM.

@bradenmacdonald
Copy link
Contributor Author

Yup, will fix that before merging. Thanks!

@bradenmacdonald bradenmacdonald force-pushed the braden/opaque-keys-cleanup branch from 92f4fbb to 9b54615 Compare April 23, 2025 21:42
@bradenmacdonald bradenmacdonald enabled auto-merge (squash) April 23, 2025 21:43
@bradenmacdonald bradenmacdonald merged commit 867e246 into openedx:master Apr 23, 2025
48 checks passed
@bradenmacdonald bradenmacdonald deleted the braden/opaque-keys-cleanup branch April 23, 2025 22:03
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Apr 23, 2025
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants