-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: [FC-86] implement index page config api #36842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-86] implement index page config api #36842
Conversation
|
Thanks for the pull request, @andrii-hantkovskyi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @diana-villalvazo-wgu, would you have a chance to review this PR when you have a moment? |
|
Could you provide context as to why the new MFE would need each of these? I would think that most of this could be handled via plugin slots instead. |
* feat: rework config endpoint to use for different lms pages
|
Closing this due to changed implementation. |
|
Reopened at #37130 |
Add Index Page Config API
This PR introduces a new API endpoint to provide dynamic configuration for the Catalog index page:
IndexPageConfigView: A Django REST Framework view at/branding/indexthat returns a JSON payload of configuration settings.configuration_helpers.get_value()with support forSiteConfigurationoverrides and fallbacks toDjango settings.The following keys are returned:
enable_course_sorting_by_start_datehomepage_overlay_htmlshow_partnersshow_homepage_promo_videohomepage_course_maxhomepage_promo_video_youtube_idUnit tests verify fallback behavior, site-specific overrides, and expected default values for all fields.