feat!: enable authoring MFE markdown editor waffle for everyone by default #36872
Conversation
kdmccormick
added
the
create-sandbox
kdmccormick
changed the title
|
Sandbox deployment successful 🚀 |
…fault This adds a migration to turn on the new React-based Markdown editing option for newly-created ProblemBlocks for all authors. The option is nested under "Advanced settings", just like the Advanced (OLX) problem editor. The migration is written such that it will *not* overwrite an existing global "No" waffle flag. Furthermore, our waffle utilities are designed such that org-level and course-level overrides will still take preference over the flag that the migration creates. Therefore, this should only take effect in cases where no existing waffle flag applies. BREAKING CHANGE: Operators who do not want the new React-based Markdown editor to be shown should create a flag contentstore.use_react_markdown_editor with the value "No". We plan to backport this to Teak. Prior art for flipping waffles like this: 9b00243 Part of: openedx/platform-roadmap#384 Co-authored-by: Muhammad Anas <muhammad.anas@arbisoft.com>
kdmccormick
force-pushed
the
kdmccormick/react-editor-on-default
branch
from
8b26f0f to
eb94113
Compare
|
Sandbox deployment failed 💥 |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been rolled back from the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
…fault (#36872) This adds a migration to turn on the new React-based Markdown editing option for newly-created ProblemBlocks for all authors. The option is nested under "Advanced settings", just like the Advanced (OLX) problem editor. The migration is written such that it will *not* overwrite an existing global "No" waffle flag. Furthermore, our waffle utilities are designed such that org-level and course-level overrides will still take preference over the flag that the migration creates. Therefore, this should only take effect in cases where no existing waffle flag applies. BREAKING CHANGE: Operators who do not want the new React-based Markdown editor to be shown should create a flag contentstore.use_react_markdown_editor with the value "No". We plan to backport this to Teak. Prior art for flipping waffles like this: 9b00243 Part of: openedx/platform-roadmap#384 Co-authored-by: Muhammad Anas <muhammad.anas@arbisoft.com>
6 participants
(based on Anas's work: #36602)
Description
This adds a migration to turn on the new React-based Markdown editing option
for newly-created ProblemBlocks for all authors. The option is nested
under "Advanced settings", just like the Advanced (OLX) problem editor.
The migration is written such that it will not overwrite an existing global "No" waffle flag. Furthermore, our waffle utilities are designed such that org-level and course-level overrides will still take preference over the flag that the migration creates. Therefore, this should only take effect in cases where no existing waffle flag applies.
BREAKING CHANGE: Operators who do not want the new React-based Markdown editor to be shown should create a flag
contentstore.use_react_markdown_editorwith the value "No".Testing information
Create a "No" entry for
contentstore.use_react_markdown_editor.Run migrations. Confirm that the "No" entry still exists.
Delete that "No" entry:
Delete the record of this PR's migration from the django_migrations table.
Run migrations again.
Follow the steps on openedx/frontend-app-authoring#1805, but notice that the waffle flag already exists.
Supporting information
Slack thread where we decided to turn this on in Teak: https://axim-collaborative.slack.com/archives/C058TVC79MF/p1749140304975279
Implementation and screenshots: openedx/frontend-app-authoring#1805
Part of: openedx/platform-roadmap#384
Prior art for turning on Waffle flags like this: https://github.com/openedx/edx-platform/blob/master/lms/djangoapps/grades/migrations/0018_add_waffle_flag_defaults.py
Other Information
This is all @Anas12091101 's work : ce4fa2c
Teak backport: #36876