Skip to content

fix: django52 tightened consistency around delete ordering and signal… #37250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awais786 merged 2 commits into from
Aug 27, 2025
Merged

fix: django52 tightened consistency around delete ordering and signal… #37250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2a9b32
fix: django52 tightened consistency around delete ordering and signal…
awais786 Aug 21, 2025
39d3128
Merge branch 'master' into fixing-dj52-deletion
awais786 Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lms/djangoapps/teams/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,10 @@ def save(self, *args, **kwargs): # lint-amnesty, pylint: disable=arguments-diff

def delete(self, *args, **kwargs): # lint-amnesty, pylint: disable=arguments-differ, signature-differs
"""Recompute the related team's team_size after deleting a membership"""
team = self.team # store reference before deleting
super().delete(*args, **kwargs)
self.team.reset_team_size()
if team and team.pk: # only reset size if team still exists
team.reset_team_size()

@classmethod
def get_memberships(cls, username=None, course_ids=None, team_ids=None):
Expand Down
Loading