Skip to content

feat!: Upgrading to django52. #37364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feanil merged 8 commits into from
Oct 7, 2025
Merged

feat!: Upgrading to django52. #37364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ae8996f
feat!: Upgrading to `django52`.
awais786 Sep 16, 2025
990f29f
chore: Run unit tests only pinned which is 5.2
awais786 Sep 24, 2025
939c7c7
Merge branch 'master' into final-dj52
awais786 Sep 24, 2025
daf5320
Merge branch 'master' into final-dj52
awais786 Oct 3, 2025
f073311
Merge branch 'master' into final-dj52
UsamaSadiq Oct 6, 2025
148a233
Merge branch 'master' into final-dj52
UsamaSadiq Oct 7, 2025
0c8e354
fix: add Djang<6.0 local constraint
UsamaSadiq Oct 7, 2025
9bf7dfa
chore: python requirements upgrade
UsamaSadiq Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
- "3.11"
django-version:
- "pinned"
- "5.2"
# When updating the shards, remember to make the same changes in
# .github/workflows/unit-tests-gh-hosted.yml
shard_name:
Expand Down
8 changes: 4 additions & 4 deletions requirements/constraints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@
# This file contains all common constraints for edx-repos
-c common_constraints.txt

# Date: 2025-10-07
# Stay on LTS version, remove once this is added to common constraint
Django<6.0

# Date: 2020-02-26
# As it is not clarified what exact breaking changes will be introduced as per
# the next major release, ensure the installed version is within boundaries.
# Issue for unpinning: https://github.com/openedx/edx-platform/issues/35280
celery>=5.2.2,<6.0.0

# Date: 2024-02-02
# Stay on LTS version, remove once this is added to common constraint
Django<5.0
Copy link
Contributor

@timmc-edx timmc-edx Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to Django<6.0 rather than being removed?

Copy link
Member

@UsamaSadiq UsamaSadiq Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the constraint to Django<6.0 instead.


# Date: 2020-02-10
# django-oauth-toolkit version >=2.0.0 has breaking changes. More details
# mentioned on this issue https://github.com/openedx/edx-platform/issues/32884
Expand Down
6 changes: 3 additions & 3 deletions requirements/edx/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ defusedxml==0.7.1
# ora2
# python3-openid
# social-auth-core
django==4.2.25
django==5.2.7
# via
# -c requirements/constraints.txt
# -r requirements/edx/kernel.in
Expand Down Expand Up @@ -277,7 +277,7 @@ django-fernet-fields-v2==0.9
# via
# edx-enterprise
# enterprise-integrated-channels
django-filter==25.1
django-filter==25.2
# via
# -r requirements/edx/kernel.in
# edx-enterprise
Expand Down Expand Up @@ -781,7 +781,7 @@ mysqlclient==2.2.7
# via
# -r requirements/edx/kernel.in
# openedx-forum
nh3==0.3.0
nh3==0.3.1
# via
# -r requirements/edx/kernel.in
# xblocks-contrib
Expand Down
6 changes: 3 additions & 3 deletions requirements/edx/development.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ distlib==0.4.0
# via
# -r requirements/edx/testing.txt
# virtualenv
django==4.2.25
django==5.2.7
# via
# -c requirements/constraints.txt
# -r requirements/edx/doc.txt
Expand Down Expand Up @@ -469,7 +469,7 @@ django-fernet-fields-v2==0.9
# -r requirements/edx/testing.txt
# edx-enterprise
# enterprise-integrated-channels
django-filter==25.1
django-filter==25.2
# via
# -r requirements/edx/doc.txt
# -r requirements/edx/testing.txt
Expand Down Expand Up @@ -1307,7 +1307,7 @@ mysqlclient==2.2.7
# -r requirements/edx/doc.txt
# -r requirements/edx/testing.txt
# openedx-forum
nh3==0.3.0
nh3==0.3.1
# via
# -r requirements/edx/doc.txt
# -r requirements/edx/testing.txt
Expand Down
6 changes: 3 additions & 3 deletions requirements/edx/doc.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ defusedxml==0.7.1
# ora2
# python3-openid
# social-auth-core
django==4.2.25
django==5.2.7
# via
# -c requirements/constraints.txt
# -r requirements/edx/base.txt
Expand Down Expand Up @@ -342,7 +342,7 @@ django-fernet-fields-v2==0.9
# -r requirements/edx/base.txt
# edx-enterprise
# enterprise-integrated-channels
django-filter==25.1
django-filter==25.2
# via
# -r requirements/edx/base.txt
# edx-enterprise
Expand Down Expand Up @@ -950,7 +950,7 @@ mysqlclient==2.2.7
# via
# -r requirements/edx/base.txt
# openedx-forum
nh3==0.3.0
nh3==0.3.1
# via
# -r requirements/edx/base.txt
# xblocks-contrib
Expand Down
6 changes: 3 additions & 3 deletions requirements/edx/testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ dill==0.4.0
# via pylint
distlib==0.4.0
# via virtualenv
django==4.2.25
django==5.2.7
# via
# -c requirements/constraints.txt
# -r requirements/edx/base.txt
Expand Down Expand Up @@ -368,7 +368,7 @@ django-fernet-fields-v2==0.9
# -r requirements/edx/base.txt
# edx-enterprise
# enterprise-integrated-channels
django-filter==25.1
django-filter==25.2
# via
# -r requirements/edx/base.txt
# edx-enterprise
Expand Down Expand Up @@ -995,7 +995,7 @@ mysqlclient==2.2.7
# via
# -r requirements/edx/base.txt
# openedx-forum
nh3==0.3.0
nh3==0.3.1
# via
# -r requirements/edx/base.txt
# xblocks-contrib
Expand Down
2 changes: 1 addition & 1 deletion scripts/user_retirement/requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ cryptography==45.0.7
# via
# -c requirements/constraints.txt
# pyjwt
django==4.2.25
django==5.2.7
# via
# -c requirements/constraints.txt
# django-crum
Expand Down
2 changes: 1 addition & 1 deletion scripts/user_retirement/requirements/testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ cryptography==45.0.7
# pyjwt
ddt==1.7.2
# via -r scripts/user_retirement/requirements/testing.in
django==4.2.25
django==5.2.7
# via
# -r scripts/user_retirement/requirements/base.txt
# django-crum
Expand Down
Loading