-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: prevent errant body string on title edit #37395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent errant body string on title edit #37395
Conversation
|
Thanks for the pull request, @asajjad2! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
5518303 to
675e370
Compare
675e370 to
761ad42
Compare
Anas12091101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
@pdpinch this PR is approved and ready to be merged. |
pdpinch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 assuming tests pass
What are the relevant tickets?
#8681
Description (What does it do?)
This change aligns the legacy discussion “Edit Post” behavior with the “New Post” form by preventing the Enter key in the title input from inserting markdown (strong text as observed in the issue) into the body. It adds a keypress handler scoped to the edit form to ignore Enter on non-editor inputs, preserving normal behavior within the body editor.
How can this be tested?
Expected: normal editor behavior (a newline is inserted). The Enter key is not blocked inside the body editor.