Skip to content

Conversation

@asajjad2
Copy link
Contributor

@asajjad2 asajjad2 commented Sep 29, 2025

What are the relevant tickets?

#8681

Description (What does it do?)

This change aligns the legacy discussion “Edit Post” behavior with the “New Post” form by preventing the Enter key in the title input from inserting markdown (strong text as observed in the issue) into the body. It adds a keypress handler scoped to the edit form to ignore Enter on non-editor inputs, preserving normal behavior within the body editor.

How can this be tested?

  1. Navigate to an LMS course discussion page → open any thread you own → click edit on the post.
  2. Click into the Title input.
  3. Press Enter and verify nothing happens:
    • The form does not submit
    • focus remains in Title
    • body is unchanged
    • no “strong text” appears in the editor preview/body.
  4. Press Tab to move focus to the body (editor textarea) and type some text, then press Enter.
    Expected: normal editor behavior (a newline is inserted). The Enter key is not blocked inside the body editor.
  5. Click Update post to save and verify no unintended markdown was inserted in the title or body.

@openedx-webhooks
Copy link

Thanks for the pull request, @asajjad2!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 29, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Sep 29, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Sep 29, 2025
@asajjad2 asajjad2 force-pushed the areeb/discussions-edit-errant-string branch from 5518303 to 675e370 Compare October 1, 2025 11:03
@asajjad2 asajjad2 force-pushed the areeb/discussions-edit-errant-string branch from 675e370 to 761ad42 Compare October 6, 2025 10:44
@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Ready for Review in Contributions Oct 8, 2025
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Oct 8, 2025
Copy link
Contributor

@Anas12091101 Anas12091101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@asajjad2
Copy link
Contributor Author

@pdpinch this PR is approved and ready to be merged.

Copy link
Contributor

@pdpinch pdpinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 assuming tests pass

@pdpinch pdpinch merged commit 264198f into openedx:master Oct 20, 2025
49 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Oct 20, 2025
@openedx-webhooks openedx-webhooks removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants