temp: Restrict forum bulk-delete to global staff only#37401
Closed
kdmccormick wants to merge 1 commit intomasterfrom
Closed
temp: Restrict forum bulk-delete to global staff only#37401kdmccormick wants to merge 1 commit intomasterfrom
kdmccormick wants to merge 1 commit intomasterfrom
Conversation
kdmccormick
force-pushed
the
kdmccormick/forum-bulk-delete-staff-only
branch
from
5904ba0 to
22f2300
Compare
kdmccormick
requested review from
brian-smith-tcril
and removed request for
brian-smith-tcril
Member
Author
|
@jristau1984 @e0d , here is one potential solution for the Forum Bulk-Delete REST API. It would keep the API as-is, but it would restrict it to global staff only. This is a stop-gap solution that would allow the REST API to continue existing in Ulmo, but without security concerns. In order to keep the REST API in the platform for Verawood, it would need to be retrofitted to support MySQL forums (in addition to MongoDB forums, which it currently supports). |
Member
Author
|
Dupe of #37683 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one potential solution for:
See that ^ issue for details and rationale.
This is a stop-gap solution so that the API can exist in Ulmo, but afterwards, we will either need to: