Skip to content

feat!: Drop the legacy course_outline page.#37462

Merged
feanil merged 4 commits intomasterfrom
feanil/drop_course_outline
Oct 20, 2025
Merged

feat!: Drop the legacy course_outline page.#37462
feanil merged 4 commits intomasterfrom
feanil/drop_course_outline

Conversation

@feanil
Copy link
Contributor

@feanil feanil commented Oct 10, 2025

Part of #36108

This page has been replaced with an equivalent page in the authoring MFE
which has been on by default since Teak. This change removes the
ability to fallback to the old page using waffle flags.

BREAKING CHANGE: The legacy_studio.course_outline waffle flag will be removed
and the code will behave as if it's always set to False. Preventing
you from falling back to the old Course Outline page.

This drops the course outline page which also drops the course_status component coming from studio-frontend which is part of the work needed before we can drop studio-frontend.

@feanil feanil force-pushed the feanil/remove_accessibility_html branch from 1f148dd to 6816ba5 Compare October 10, 2025 19:38
@feanil feanil changed the base branch from feanil/remove_accessibility_html to feanil/drop_course_home October 10, 2025 19:39
@feanil feanil force-pushed the feanil/drop_course_outline branch 2 times, most recently from 6086205 to c863072 Compare October 10, 2025 19:41
@feanil feanil force-pushed the feanil/drop_course_home branch from 37dfbc4 to 7057510 Compare October 14, 2025 20:29
@feanil feanil force-pushed the feanil/drop_course_outline branch from c863072 to 7459727 Compare October 14, 2025 20:29
@feanil feanil marked this pull request as ready for review October 14, 2025 21:13
@feanil feanil force-pushed the feanil/drop_course_home branch 2 times, most recently from ade2299 to 4375bf5 Compare October 16, 2025 19:04
@feanil feanil force-pushed the feanil/drop_course_outline branch from 7459727 to 1a53f68 Compare October 16, 2025 19:05
"""
course_key = self.get_course_key()
return toggles.use_new_course_outline_page(course_key)
return True
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API will get cleaned up as a part of #37497

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, and generally speaking, can you put the ticket link in the code?

@feanil feanil requested a review from kdmccormick October 17, 2025 14:06
@feanil feanil force-pushed the feanil/drop_course_home branch from 4375bf5 to 7c8020d Compare October 17, 2025 14:25
@feanil feanil force-pushed the feanil/drop_course_outline branch from 1a53f68 to 8e5df6c Compare October 17, 2025 14:25
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the ticket link, looks great otherwise 🔥

feanil and others added 4 commits October 20, 2025 10:26
This page has been replaced with an equivalent page in the authoring MFE
which has been on by default since Teak.  This change removes the
ability to fallback to the old page using waffle flags.

BREAKING CHANGE: The `legacy_studio.course_outline` waffle flag will be removed
and the code will behave as if it's always set to `False`. Preventing
you from falling back to the old Course Outline page.
The tests were testing a set of menu items that were specifically
available on the old course_outline page.  Since the page is never
rendered we don't need to test to see if those header items are actually
rendered.

As we finish the rest of the studio frontend cleanup, the header itself
should be removed but just removing these tests since they relied on
conditional bits of the header for when it was showing a course outline.
The removed tests either needed to check things on the outline page
which makes them not relevant tests, or they just needed data from the
course_handler which they can get from json now.
Co-authored-by: Kyle McCormick <kyle@axim.org>
@feanil feanil force-pushed the feanil/drop_course_outline branch from d9680d2 to 83cfa1d Compare October 20, 2025 14:27
Base automatically changed from feanil/drop_course_home to master October 20, 2025 15:46
@feanil feanil merged commit c2d65c9 into master Oct 20, 2025
48 checks passed
@feanil feanil deleted the feanil/drop_course_outline branch October 20, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants