Conversation
I was looking at these files for some other reason and saw that these imports were unused. Some of it looks like an artifact of the hoisting of some settings up to the `openedx/env/common.py` file and others look like some ancient unused imports.
Co-authored-by: Kyle McCormick <kyle@axim.org>
Contributor
|
[request] I haven't looked closely at this, but I just ask that anything that is somewhat risky and doesn't really matter whether it lands in Ulmo and Verawood, can we simply delay merge by a day or so? You'll do what you will, but Ulmo cut was already delayed, and we keep getting more changes that we need to bring in if we wish to use Ulmo point releases. Thank you. Post-ulmo cut, you should never hear me ask about this again. ;) |
haftamuk
pushed a commit
to haftamuk/edx-platform
that referenced
this pull request
Nov 3, 2025
* style: Drop unused imports. I was looking at these files for some other reason and saw that these imports were unused. Some of it looks like an artifact of the hoisting of some settings up to the `openedx/env/common.py` file and others look like some ancient unused imports. Co-authored-by: Kyle McCormick <kyle@axim.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at these files for some other reason and saw that these
imports were unused. Some of it looks like an artifact of the hoisting
of some settings up to the
openedx/env/common.pyfile and others looklike some ancient unused imports.
I tested this with the diff_settings.sh script and the only difference was the different memory addresses of the FeaturesProxy object.