Skip to content

Update tabs.py #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oliviermarquez wants to merge 3 commits into from
Closed

Update tabs.py #757

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff27882
Update tabs.py
oliviermarquez Aug 21, 2013
8d5c953
Update tabs.py
oliviermarquez Aug 21, 2013
33b3838
Update tabs.py
oliviermarquez Aug 23, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cms/djangoapps/contentstore/views/tabs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ def initialize_course_tabs(course):

# This logic is repeated in xmodule/modulestore/tests/factories.py
# so if you change anything here, you need to also change it there.
course.tabs = [{"type": "courseware"},
{"type": "course_info", "name": "Course Info"},
{"type": "discussion", "name": "Discussion"},
{"type": "wiki", "name": "Wiki"},
{"type": "progress", "name": "Progress"}]
course.tabs = [{"type": "courseware", "name": _("Courseware")},
{"type": "course_info", "name": _("Course Info")},
{"type": "discussion", "name": _("Discussion")},
{"type": "wiki", "name": _("Wiki")},
{"type": "progress", "name": _("Progress")}]
Copy link
Contributor

@sarina sarina Oct 4, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With respect to breaking long lines, please see https://github.com/edx/edx-platform/wiki/Python-Guidelines

It's more readable to be like

course.tabs = [
    {"type": "courseware"},
    ....
    {"type": "progress", "name": _("Progress")},
]

The trailing comma I put at the end of "progress" line is OK - it's Python! 😄


modulestore('direct').update_metadata(course.location.url(), own_metadata(course))

Expand Down