Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add xblock-adventure to the translation pipeline #251

Closed
wants to merge 1 commit into from
Closed

feat: Add xblock-adventure to the translation pipeline #251

wants to merge 1 commit into from

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Apr 30, 2023 •
edited
Loading

feat: Add xblock-adventure to the translation pipeline

IMPORTANT: This PR needs openedx-unsupported/xblock-adventure#54 before it's merged.

Refs:
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
see details here

@openedx-webhooks
Copy link

openedx-webhooks commented Apr 30, 2023 •
edited
Loading

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 30, 2023
@shadinaif shadinaif marked this pull request as ready for review April 30, 2023 15:08
@brian-smith-tcril brian-smith-tcril added the blocked by other work PR cannot be finished until other work is complete label May 4, 2023
OmarIthawi
OmarIthawi approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing new permissions, not a real review

@OmarIthawi OmarIthawi self-requested a review June 7, 2023 12:08
@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.xblock-adventure branch from 44e8448 to 70b533a Compare June 8, 2023 11:47
@OmarIthawi OmarIthawi marked this pull request as draft July 22, 2023 17:29
@shadinaif
Copy link
Contributor Author

The XBlock is Deprecated openedx-unsupported/xblock-adventure#54

@shadinaif shadinaif closed this Sep 13, 2023
@openedx-webhooks
Copy link

@shadinaif Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@shadinaif Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@shadinaif shadinaif deleted the shadinaif/FC-0012-OEP-58.xblock-adventure branch September 13, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarIthawi OmarIthawi OmarIthawi approved these changes

Assignees
No one assigned
Labels
blocked by other work PR cannot be finished until other work is complete open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shadinaif @openedx-webhooks @OmarIthawi @brian-smith-tcril