Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a plugin for the Learner Dashboard MFE #4

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

arbrandes
Copy link
Contributor

@arbrandes arbrandes commented Jun 9, 2023

return mfes

hooks.Filters.ENV_TEMPLATE_VARIABLES.add_items(
[("learner_dashboard_port", port)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for thoughts here, @regisb: is there a better way to get the port to openedx-lms-development-settings with the new MFE_APPS mechanism?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the very late reply... If it were for me, I would just hardcode the port :-p But I understand it's not very elegant. Instead, we could add a get_mfe utility function to the ENV_TEMPLATE_VARIABLES in the tutor-mfe plugin:

def get_mfe(name: str):
    return MFE_APPS.get(name)

tutor_hooks.Filters.ENV_TEMPLATE_VARIABLES.add_item(("get_mfe", get_mfe))

@arbrandes arbrandes force-pushed the learner-dashboard branch 2 times, most recently from 464d84c to a273f92 Compare June 13, 2023 16:57
@arbrandes arbrandes marked this pull request as ready for review June 14, 2023 13:25
Adds an experimental plugin for the Learner Dashboard (a.k.a. "Learner
Home") MFE.
@arbrandes
Copy link
Contributor Author

Alright, since this is experimental anyway, I'm going ahead and merging it so we can mention the plugin in the release notes.

@arbrandes arbrandes merged commit bc8bdd2 into openedx:main Jun 14, 2023
@arbrandes arbrandes deleted the learner-dashboard branch June 14, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants