fix: <Icon/> types still weren't correct

openedx · Mar 13, 2024 · 3b3d91e · 3b3d91e
1 parent bbe900f
commit 3b3d91e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Icon/Icon.test.tsx b/src/Icon/Icon.test.tsx
@@ -102,5 +102,13 @@ describe('<Icon />', () => {
 
       expect(iconSpan.classList.contains('pgn__icon__xs')).toEqual(true);
     });
+
+    it('receives style or other arbitrary HTML properties correctly', () => {
+      const { container } = render(<Icon src={BlankSrc} style={{ color: 'red' }} size="xs" />);
+      const iconSpans = container.querySelectorAll('span');
+      const iconSpan = iconSpans[0];
+
+      expect(iconSpan.style.color).toEqual('red');
+    });
   });
 });
diff --git a/src/Icon/index.d.ts b/src/Icon/index.d.ts
@@ -1,6 +1,6 @@
 import React from 'react';
 
-export interface IconProps {
+export interface IconProps extends React.ComponentPropsWithoutRef<'span'> {
   src?: React.ReactElement | Function;
   svgAttrs?: {
     'aria-label'?: string;