Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove second tab stop for <HyperLink> wrapper around Card component #2200

Closed
kalebjdavenport opened this issue Apr 18, 2023 · 1 comment · Fixed by #2290
Closed

fix: Remove second tab stop for <HyperLink> wrapper around Card component #2200

kalebjdavenport opened this issue Apr 18, 2023 · 1 comment · Fixed by #2290
Assignees
@PKulkoRaccoonGang
Labels
a11y Relates to platform accessibility bug Report of or fix for something that isn't working as intended maintenance Routine upkeep necessary for the health of the platform raccoon-gang

Comments

@kalebjdavenport
Copy link
Contributor

Currently the Card component has an isClickable prop that correctly makes the tab stop select the whole card. However, there is a secondary implementation where you wrap a component that does not have the isClickable prop with a link and it should operate similarly to the version of the card with the isClickable prop.

Acceptance Criteria

  • ensure the second implementation of the Card wrapped in a link has only one tab stop with the correct selection styles.
@kalebjdavenport kalebjdavenport added the maintenance Routine upkeep necessary for the health of the platform label Apr 18, 2023
@kalebjdavenport kalebjdavenport self-assigned this Apr 18, 2023
@adamstankiewicz adamstankiewicz mentioned this issue May 5, 2023
Closed
@adamstankiewicz adamstankiewicz added bug Report of or fix for something that isn't working as intended a11y Relates to platform accessibility raccoon-gang labels May 5, 2023
@adamstankiewicz adamstankiewicz linked a pull request May 19, 2023 that will close this issue
[BD-46] fix: fixed double tab and styles clickable card component #2290
Merged
10 tasks
@adamstankiewicz
Copy link
Member

Closed via #2290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PKulkoRaccoonGang PKulkoRaccoonGang

Labels
a11y Relates to platform accessibility bug Report of or fix for something that isn't working as intended maintenance Routine upkeep necessary for the health of the platform raccoon-gang
Projects
Paragon Working Group
Status: Done
Milestone
No milestone
3 participants
@adamstankiewicz @kalebjdavenport @PKulkoRaccoonGang